Mesa (master): radv: fix memory leak when restoring from cache

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jul 11 00:44:47 UTC 2019


Module: Mesa
Branch: master
Commit: ae4ccb67be29b9bca5c3ba8e5ed175901e1645b6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ae4ccb67be29b9bca5c3ba8e5ed175901e1645b6

Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Wed Jul 10 14:11:23 2019 +1000

radv: fix memory leak when restoring from cache

Fixes: 726a31df705b ("radv: Add the concept of radv shader binaries.")

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

---

 src/amd/vulkan/radv_pipeline_cache.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/amd/vulkan/radv_pipeline_cache.c b/src/amd/vulkan/radv_pipeline_cache.c
index 2b3fda6eb8e..b773de30c32 100644
--- a/src/amd/vulkan/radv_pipeline_cache.c
+++ b/src/amd/vulkan/radv_pipeline_cache.c
@@ -309,6 +309,7 @@ radv_create_shader_variants_from_pipeline_cache(struct radv_device *device,
 			p += entry->binary_sizes[i];
 
 			entry->variants[i] = radv_shader_variant_create(device, binary);
+			free(binary);
 		} else if (entry->binary_sizes[i]) {
 			p += entry->binary_sizes[i];
 		}




More information about the mesa-commit mailing list