Mesa (master): panfrost: Remove bizarre hack
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Jul 15 15:04:04 UTC 2019
Module: Mesa
Branch: master
Commit: 594b47d91754a0298c315bfdceef0d3e6174ee9a
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=594b47d91754a0298c315bfdceef0d3e6174ee9a
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Fri Jul 12 16:37:45 2019 -0700
panfrost: Remove bizarre hack
I don't think this is still necessary, and if it is, we'll have to
figure out how to fix it the right way.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
---
src/gallium/drivers/panfrost/pan_context.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c
index 7171841693c..710752f6cb5 100644
--- a/src/gallium/drivers/panfrost/pan_context.c
+++ b/src/gallium/drivers/panfrost/pan_context.c
@@ -1847,15 +1847,6 @@ panfrost_create_vertex_elements_state(
so->num_elements = num_elements;
memcpy(so->pipe, elements, sizeof(*elements) * num_elements);
- /* XXX: What the cornball? This is totally, 100%, unapologetically
- * nonsense. And yet it somehow fixes a regression in -bshadow
- * (previously, we allocated the descriptor here... a newer commit
- * removed that allocation, and then memory corruption led to
- * shader_meta getting overwritten in bad ways and then the whole test
- * case falling apart . TODO: LOOK INTO PLEASE XXX XXX BAD XXX XXX XXX
- */
- panfrost_allocate_chunk(pan_context(pctx), 0, HEAP_DESCRIPTOR);
-
for (int i = 0; i < num_elements; ++i) {
so->hw[i].index = i;
More information about the mesa-commit
mailing list