Mesa (master): panfrost: Don't leak the blend CSO hash table

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Jul 15 23:14:21 UTC 2019


Module: Mesa
Branch: master
Commit: fea953e6c2519560371b29303e0bd014963c14d9
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fea953e6c2519560371b29303e0bd014963c14d9

Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jul 15 11:37:42 2019 -0700

panfrost: Don't leak the blend CSO hash table

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

---

 src/gallium/drivers/panfrost/pan_blend_cso.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/gallium/drivers/panfrost/pan_blend_cso.c b/src/gallium/drivers/panfrost/pan_blend_cso.c
index cf26d7366ee..f2dafe062ce 100644
--- a/src/gallium/drivers/panfrost/pan_blend_cso.c
+++ b/src/gallium/drivers/panfrost/pan_blend_cso.c
@@ -124,7 +124,7 @@ panfrost_create_blend_state(struct pipe_context *pipe,
                 /* Regardless if that works, we also need to initialize
                  * the blend shaders */
 
-                rt->shaders = _mesa_hash_table_u64_create(NULL);
+                rt->shaders = _mesa_hash_table_u64_create(so);
         }
 
         return so;
@@ -152,8 +152,7 @@ static void
 panfrost_delete_blend_state(struct pipe_context *pipe,
                             void *blend)
 {
-        /* TODO: leaks internally? */
-
+        /* TODO: Free shader binary? */
         ralloc_free(blend);
 }
 




More information about the mesa-commit mailing list