Mesa (master): radv: fix dumping disassembly with RADV_DEBUG=shaders

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jul 23 08:22:30 UTC 2019


Module: Mesa
Branch: master
Commit: 9343c93e34b559d29f62209ed832f9f11773515a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9343c93e34b559d29f62209ed832f9f11773515a

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Tue Jul 23 09:55:24 2019 +0200

radv: fix dumping disassembly with RADV_DEBUG=shaders

Fixes: a20a9d0c5e7 ("radv: dont store disasm string unless keep_shader_info flag set")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

---

 src/amd/vulkan/radv_shader.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
index 3adaf52e152..736388c555c 100644
--- a/src/amd/vulkan/radv_shader.c
+++ b/src/amd/vulkan/radv_shader.c
@@ -1013,7 +1013,8 @@ radv_shader_variant_create(struct radv_device *device,
 			return NULL;
 		}
 
-		if (device->keep_shader_info) {
+		if (device->keep_shader_info ||
+		    (device->instance->debug_flags & RADV_DEBUG_DUMP_SHADERS)) {
 			const char *disasm_data;
 			size_t disasm_size;
 			if (!ac_rtld_get_section_by_name(&rtld_binary, ".AMDGPU.disasm", &disasm_data, &disasm_size)) {




More information about the mesa-commit mailing list