Mesa (master): nir/gather_info: Move setting uses_64bit out of the switch

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jul 23 18:41:13 UTC 2019


Module: Mesa
Branch: master
Commit: 41ab92a327c63bdf97edee356e46246f4ff306bc
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=41ab92a327c63bdf97edee356e46246f4ff306bc

Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Fri Jun  7 18:03:10 2019 -0500

nir/gather_info: Move setting uses_64bit out of the switch

Otherwise, as we add things to the switch, we're going to forget and add
some 64-bit op at some point in the future and it'll stop getting
flagged.  There's no reason why we can't do the check for derivatives.

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/compiler/nir/nir_gather_info.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/compiler/nir/nir_gather_info.c b/src/compiler/nir/nir_gather_info.c
index 04a1f9b38bc..51717cd6d7f 100644
--- a/src/compiler/nir/nir_gather_info.c
+++ b/src/compiler/nir/nir_gather_info.c
@@ -302,13 +302,14 @@ gather_alu_info(nir_alu_instr *instr, nir_shader *shader)
       shader->info.uses_fddx_fddy = true;
       break;
    default:
-      shader->info.uses_64bit |= instr->dest.dest.ssa.bit_size == 64;
-      unsigned num_srcs = nir_op_infos[instr->op].num_inputs;
-      for (unsigned i = 0; i < num_srcs; i++) {
-         shader->info.uses_64bit |= nir_src_bit_size(instr->src[i].src) == 64;
-      }
       break;
    }
+
+   shader->info.uses_64bit |= instr->dest.dest.ssa.bit_size == 64;
+   unsigned num_srcs = nir_op_infos[instr->op].num_inputs;
+   for (unsigned i = 0; i < num_srcs; i++) {
+      shader->info.uses_64bit |= nir_src_bit_size(instr->src[i].src) == 64;
+   }
 }
 
 static void




More information about the mesa-commit mailing list