Mesa (staging/19.1): meson: add a warning for meson < 0.46.0

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jul 30 15:08:02 UTC 2019


Module: Mesa
Branch: staging/19.1
Commit: 23eebaf2ec5d7820e5d4c902fbe8456dcb65d58c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=23eebaf2ec5d7820e5d4c902fbe8456dcb65d58c

Author: Andrii Simiklit <andrii.simiklit at globallogic.com>
Date:   Tue Jul 30 11:44:55 2019 +0300

meson: add a warning for meson < 0.46.0

This could help somebody to be noticed about meson issue:
https://github.com/mesonbuild/meson/pull/3274
as result NDEBUG won't be defined even if b_ndebug is true
and buildtype is release.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109791
Cc: mesa-stable at lists.freedesktop.org
Acked-by: Eric Engestrom <eric.engestrom at intel.com>
Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>

---

 meson.build | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meson.build b/meson.build
index 7bc199b293e..6eda16785f9 100644
--- a/meson.build
+++ b/meson.build
@@ -190,6 +190,12 @@ if cc.get_id() == 'intel'
   endif
 endif
 
+#This message is needed until we bump meson version to 0.46 because of known 0.45.0 and 0.45.1 issue
+#https://bugs.freedesktop.org/show_bug.cgi?id=109791
+if meson.version().version_compare('< 0.46.0')
+    warning('''Meson < 0.46 doesn't automatically define `NDEBUG`; please update meson to at least 0.46.''')
+endif
+
 with_gallium = gallium_drivers.length() != 0 and gallium_drivers != ['']
 
 if with_gallium and system_has_kms_drm




More information about the mesa-commit mailing list