Mesa (master): freedreno: Drop invalid scissor optimization.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jun 4 23:57:22 UTC 2019


Module: Mesa
Branch: master
Commit: 36cb2097874d42a2cd69f8862b4d8dc72e42327f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=36cb2097874d42a2cd69f8862b4d8dc72e42327f

Author: Eric Anholt <eric at anholt.net>
Date:   Fri May 17 09:55:40 2019 -0700

freedreno: Drop invalid scissor optimization.

We do support TF now, so it's no longer valid.  Besides, if we want this
optimization, we should probably have mesa/st doing it right for everyone.

Reviewed-by: Rob Clark <robdclark at gmail.com>

---

 src/gallium/drivers/freedreno/freedreno_draw.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/gallium/drivers/freedreno/freedreno_draw.c b/src/gallium/drivers/freedreno/freedreno_draw.c
index ae7be1ab5a1..2908ac52c9c 100644
--- a/src/gallium/drivers/freedreno/freedreno_draw.c
+++ b/src/gallium/drivers/freedreno/freedreno_draw.c
@@ -64,7 +64,6 @@ fd_draw_vbo(struct pipe_context *pctx, const struct pipe_draw_info *info)
 	struct fd_context *ctx = fd_context(pctx);
 	struct fd_batch *batch = fd_context_batch(ctx);
 	struct pipe_framebuffer_state *pfb = &batch->framebuffer;
-	struct pipe_scissor_state *scissor = fd_context_get_scissor(ctx);
 	unsigned i, prims, buffers = 0, restore_buffers = 0;
 
 	/* for debugging problems with indirect draw, it is convenient
@@ -81,12 +80,6 @@ fd_draw_vbo(struct pipe_context *pctx, const struct pipe_draw_info *info)
 	    !u_trim_pipe_prim(info->mode, (unsigned*)&info->count))
 		return;
 
-	/* if we supported transform feedback, we'd have to disable this: */
-	if (((scissor->maxx - scissor->minx) *
-			(scissor->maxy - scissor->miny)) == 0) {
-		return;
-	}
-
 	/* TODO: push down the region versions into the tiles */
 	if (!fd_render_condition_check(pctx))
 		return;




More information about the mesa-commit mailing list