Mesa (master): nouveau: Use nir_lower_doubles instead of lower_fmod64 on nvc0.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jun 5 23:56:31 UTC 2019


Module: Mesa
Branch: master
Commit: d13059f4d50d370eec76495dd2b51fdf5c6e1aee
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d13059f4d50d370eec76495dd2b51fdf5c6e1aee

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Mon Jun  3 11:43:38 2019 -0700

nouveau: Use nir_lower_doubles instead of lower_fmod64 on nvc0.

We currently have two duplicate mechanisms for lowering fmod at 64.
One is a nir_opt_algebraic rule keyed off of options->lower_fmod64,
and the other is nir_lower_doubles, which offers a full gamut of
fp64 lowering.  The latter works slightly better in some corner cases,
so I'm trying to eliminate lower_fmod64 and drop the redundancy.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

---

 src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
index 998116fc251..09f8c4135e5 100644
--- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
+++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
@@ -906,7 +906,6 @@ static const nir_shader_compiler_options nir_options = {
    .lower_fsat = false,
    .lower_fsqrt = false, // TODO: only before gm200
    .lower_fmod32 = true,
-   .lower_fmod64 = true,
    .lower_bitfield_extract = false,
    .lower_bitfield_extract_to_shifts = false,
    .lower_bitfield_insert = false,
@@ -955,7 +954,7 @@ static const nir_shader_compiler_options nir_options = {
    .lower_mul_2x32_64 = true, // TODO
    .max_unroll_iterations = 32,
    .lower_int64_options = nir_lower_divmod64, // TODO
-   .lower_doubles_options = 0, // TODO
+   .lower_doubles_options = nir_lower_dmod, // TODO
 };
 
 static const void *




More information about the mesa-commit mailing list