Mesa (master): v3d: fix checking twice auf flag

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jun 13 09:46:30 UTC 2019


Module: Mesa
Branch: master
Commit: 17c2c9cd67797e8e741859015c123b26c4fa293f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=17c2c9cd67797e8e741859015c123b26c4fa293f

Author: Alejandro Piñeiro <apinheiro at igalia.com>
Date:   Wed Jun 12 14:49:05 2019 +0200

v3d: fix checking twice auf flag

Seems a C&P error, and should check for auf/muf.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110902
Fixes: 8f065596d22ab000c53f "v3d: Add an optimization pass for redundant flags updates."

Reviewed-by: Eric Anholt <eric at anholt.net>

---

 src/broadcom/compiler/vir_opt_redundant_flags.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/broadcom/compiler/vir_opt_redundant_flags.c b/src/broadcom/compiler/vir_opt_redundant_flags.c
index 61ebf5dfa24..8749f3cd647 100644
--- a/src/broadcom/compiler/vir_opt_redundant_flags.c
+++ b/src/broadcom/compiler/vir_opt_redundant_flags.c
@@ -102,7 +102,7 @@ vir_opt_redundant_flags_block(struct v3d_compile *c, struct qblock *block)
         vir_for_each_inst(inst, block) {
                 if (inst->qpu.type != V3D_QPU_INSTR_TYPE_ALU ||
                     inst->qpu.flags.auf != V3D_QPU_UF_NONE ||
-                    inst->qpu.flags.auf != V3D_QPU_UF_NONE) {
+                    inst->qpu.flags.muf != V3D_QPU_UF_NONE) {
                         last_flags = NULL;
                         continue;
                 }




More information about the mesa-commit mailing list