Mesa (master): panfrost: Disable pipelining temporarily

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Jun 17 16:33:41 UTC 2019


Module: Mesa
Branch: master
Commit: 3a9b7692f1aecad3947fd2d4f8c3d2a947a16335
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3a9b7692f1aecad3947fd2d4f8c3d2a947a16335

Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 17 09:25:52 2019 -0700

panfrost: Disable pipelining temporarily

Pipelined rendering is important for performance but is not working
right these days. Disable it for correctness until the panfrost_job
refactor is enabled and we can do it right.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

---

 src/gallium/drivers/panfrost/pan_context.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c
index c877ae5396e..7ad20a80fb1 100644
--- a/src/gallium/drivers/panfrost/pan_context.c
+++ b/src/gallium/drivers/panfrost/pan_context.c
@@ -1495,8 +1495,10 @@ panfrost_flush(
 	if (!job->clear)
 	        panfrost_draw_wallpaper(&ctx->base);
 
-        /* Whether to stall the pipeline for immediately correct results */
-        bool flush_immediate = flags & PIPE_FLUSH_END_OF_FRAME;
+        /* Whether to stall the pipeline for immediately correct results. Since
+         * pipelined rendering is quite broken right now (to be fixed by the
+         * panfrost_job refactor, just take the perf hit for correctness) */
+        bool flush_immediate = /*flags & PIPE_FLUSH_END_OF_FRAME*/true;
 
         /* Submit the frame itself */
         panfrost_submit_frame(ctx, flush_immediate, fence, job);




More information about the mesa-commit mailing list