Mesa (master): freedreno: Stop reporting max_const in shader-db.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sat Jun 22 00:16:35 UTC 2019


Module: Mesa
Branch: master
Commit: 23a7feda6310fa2d87ec94939c743f1aa133048b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=23a7feda6310fa2d87ec94939c743f1aa133048b

Author: Eric Anholt <eric at anholt.net>
Date:   Wed Jun  5 15:00:57 2019 -0700

freedreno: Stop reporting max_const in shader-db.

We end up uploading constlen regardless, so max_const would only get
you slightly improved granularity in const usage in comparison.

Reviewed-by: Rob Clark <robdclark at gmail.com>

---

 src/freedreno/ir3/ir3_shader.c                  | 4 +---
 src/gallium/drivers/freedreno/ir3/ir3_gallium.c | 3 +--
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/freedreno/ir3/ir3_shader.c b/src/freedreno/ir3/ir3_shader.c
index 610ae655a83..228c7609f50 100644
--- a/src/freedreno/ir3/ir3_shader.c
+++ b/src/freedreno/ir3/ir3_shader.c
@@ -417,9 +417,7 @@ ir3_shader_disasm(struct ir3_shader_variant *so, uint32_t *bin, FILE *out)
 			so->info.max_half_reg + 1,
 			so->info.max_reg + 1);
 
-	fprintf(out, "; %d const, %u constlen\n",
-			so->info.max_const + 1,
-			so->constlen);
+	fprintf(out, "; %u constlen\n", so->constlen);
 
 	fprintf(out, "; %u (ss), %u (sy)\n", so->info.ss, so->info.sy);
 
diff --git a/src/gallium/drivers/freedreno/ir3/ir3_gallium.c b/src/gallium/drivers/freedreno/ir3/ir3_gallium.c
index 4a7d3e8dbfd..35693f97c3b 100644
--- a/src/gallium/drivers/freedreno/ir3/ir3_gallium.c
+++ b/src/gallium/drivers/freedreno/ir3/ir3_gallium.c
@@ -52,7 +52,7 @@ dump_shader_info(struct ir3_shader_variant *v, bool binning_pass,
 
 	pipe_debug_message(debug, SHADER_INFO,
 			"%s%s shader: %u inst, %u dwords, "
-			"%u half, %u full, %u const, %u constlen, "
+			"%u half, %u full, %u constlen, "
 			"%u (ss), %u (sy), %d max_sun, %d loops\n",
 			binning_pass ? "B" : "",
 			ir3_shader_stage(v->shader),
@@ -60,7 +60,6 @@ dump_shader_info(struct ir3_shader_variant *v, bool binning_pass,
 			v->info.sizedwords,
 			v->info.max_half_reg + 1,
 			v->info.max_reg + 1,
-			v->info.max_const + 1,
 			v->constlen,
 			v->info.ss, v->info.sy,
 			v->max_sun, v->loops);




More information about the mesa-commit mailing list