Mesa (master): 30 new commits

Tue Jun 25 21:39:15 UTC 2019

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e8f4c9f56c068411389ea87ae4c2a772b77d273e
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Jun 25 13:42:58 2019 -0700

    panfrost/ci: Add RK3288 flipflops I don't want to deal with right now
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=70a87a915d0a26cf976629745a089c06ddd75a9b
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 24 10:16:33 2019 -0700

    panfrost/ci: Update failures list
    
    A ton of tests were fixed by this series. A few were incorrectly passing
    before (QualityError, for instance) and now are explicitly failing. A
    few legitimate regressions but overwhelmingly positive.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ddf5f04edfdda8d013d564e889ad840792efd7ec
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 24 13:17:28 2019 -0700

    panfrost/ci: Set MESA_GLES_VERSION_OVERRIDE=3.0
    
    Fixes cube map tests due to disagreements between Mesa, dEQP, and the
    spec...
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Cc: Tomeu Vizoso <tomeu.vizoso at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=33f3cac1c222327dfc19ee71ea8002097eab4691
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 24 15:06:47 2019 -0700

    panfrost/ci: Run full set of mipmap tests
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f34635c6994da0789e3158a69176c55d4ba1d2bf
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Jun 25 07:01:52 2019 -0700

    panfrost: Advertise support for other 8-bit UNORM formats
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=310ca6ba4048dc3719945c438d70d1f1d7ab5689
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Jun 25 08:57:55 2019 -0700

    panfrost: Use pipe_surface->format directly in blitter
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5cfb4248c6eb5afdc00b3893178e87af37dcf309
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Jun 25 08:51:48 2019 -0700

    panfrost: Invert swizzle for rendering
    
    Fixes rendering to e.g. alpha textures.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b96f119d853203945c4174145679669afabc1edf
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 24 14:53:54 2019 -0700

    panfrost: Honour first_layer...last_layer when sampling
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0ad17f56ae2357af585766367d62cefd75429383
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 24 14:39:37 2019 -0700

    panfrost: Use the sampler_view target (not the textures)
    
    u_blitter gets "special treatment" and uses this mechanism to cast
    cube maps to 2D textures in order to texelFetch them.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=faf8ad4875b61a546a1d197d4542ed5d77d65417
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 24 14:39:25 2019 -0700

    panfrost/midgard: Assert guard texelFetch against cubemaps
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=124f6b541b75c96ff265b0dcf05fb40e0f1e9e29
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 24 14:13:20 2019 -0700

    panfrost: Zero pixels in any axis is zero pixels total
    
    Multiplication, not addition, so switch the logic operator.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=06211f45a7fd76c29ba4369542b6f2eb04e1d034
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 24 13:53:44 2019 -0700

    panfrost: Respect mip level when wallpapering
    
    Fixes DATA_INVALID_FAULT raised when wallpapering while rendering to a
    mipmap.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6729912a4bba88e6d0af8560bc9de692d044c906
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 24 10:35:03 2019 -0700

    panfrost/midgard: Fixup NIR texture op
    
    In a vertex shader, a tex op should map to txl, as there *must* be a LOD
    given to the hardware (implicitly or explicitly).
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=17adcfc0085fda75ea7b837cb7830d04a5a3764d
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 24 09:16:11 2019 -0700

    panfrost: Support (non-)seamless cube maps
    
    Identify the seamless cubemap bit and passthrough the Gallium state
    rather than setting unconditionally.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3e6c6bb0af971a7bc9a24f492b3dd8b0b26ffa68
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jun 24 07:08:52 2019 -0700

    panfrost: Merge checksum buffer with main BO
    
    This is similar to the AFBC merge; now all (non-imported) buffers use a
    common backing buffer. Reenables checksumming, eliminating a performance
    regression.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a9fc1c8399742eb08c04e34000a9dac4c74d5ff6
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Sun Jun 23 11:29:46 2019 -0700

    panfrost/decode: Limit MRT blend count
    
    I thought I already fixed this. Maybe that was a dream...? Then again, I
    might be dreaming now.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=65e9d9b625460ab6e18c58173a1c0a6f72a835ef
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Sun Jun 23 11:20:00 2019 -0700

    panfrost: Clamp tile coordinates before job submission
    
    Fixes TILE_RANGE_FAULT raised on some tests in
    dEQP-GLES3.functional.fbo.blit.*
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7005c0d83b7d33158cabf204a00f6f80f984cdaa
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Sun Jun 23 11:05:10 2019 -0700

    panfrost: Use dedicated u_blitter context for wallpapers
    
    The main ctx->blitter instance should be reserved for blits originated
    from Gallium (like mipmap generation). Since wallpapering is
    conceptually different -- wallpaper blits can be triggered by Gallium
    blits -- the blitter pipes must be separate to avoid potential u_blitter
    recursion.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=64b7bd3f9042855389cde992134c4f3b51f3687f
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Jun 21 17:39:02 2019 -0700

    panfrost: Sanity check layer
    
    It doesn't make sense to try to render to multiple array elements at
    once.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=eb3c09716b886365c201fb0178dd9512fed1f22d
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Jun 21 17:27:05 2019 -0700

    panfrost: Divide array_size by 6 for cubemaps
    
    Addresses the disparity between Mali and Gallium definitions of
    array_size.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=65bc56b5683283859c12944dee653d4a0a1088f5
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Jun 21 17:23:49 2019 -0700

    panfrost: Use get_texture_address for framebuffer computations
    
    Allows for sharing some code as well as theoretically allowing cubemap
    rendering.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3609b50a64430d9eaefd3473d9ad96910e87002c
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Jun 21 14:54:44 2019 -0700

    panfrost: Merge AFBC slab with BO backing
    
    Rather than tracking AFBC memory "specially", just use the same codepath
    as linear and tiled. Less things to mess up, I figure. This allows us to
    use the standard setup_slices() call with AFBC resources, allowing
    mipmapped AFBC resources.
    
    Unfortunately, we do have to disable AFBC (and checksumming) in the
    meantime to avoid functional regressions, as we don't know _a priori_ if
    we'll need to access a resource from software (which is not yet hooked
    up with AFBC) and we don't yet have routines to switch the layout of a
    BO at runtime.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=aea3f0ac1d1e281b5d2f2100acad87810ed309c0
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Jun 21 14:41:14 2019 -0700

    panfrost: Z/S can't be tiled
    
    As far as we know, Utgard-style tiling only works for color render
    targets, not depth/stencil, so ensure we don't try to tile it (rather
    than compress or plain old linear) and drive ourselves into a corner.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ad56dd4e973e181db394fbc68c7f82dfb6f505f8
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Jun 21 14:26:19 2019 -0700

    panfrost: Enable mipmapping
    
    Now the autogeneration of mipmaps is working (via u_blitter), we can
    finally enable mipmaps!
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5aeffa95175dedc234fb640c188f8ba48b3f8e8c
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Jun 21 14:25:59 2019 -0700

    panfrost: Enable blitting
    
    Now that all the prerequisites breaking u_blitter are fixed, we can
    finally hook up panfrost_blit.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=06d192c742eb429af8002802048254031d122593
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Sun Jun 23 11:49:49 2019 -0700

    panfrost: Allow texelFetch for wallpaper blits
    
    We just implemented the routine; we may as well use it.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f4bb7f096c84b783d0b4c8f33b1d751b98b67895
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Jun 21 16:17:34 2019 -0700

    panfrost/midgard: Implement texelFetch (2D only)
    
    txf instructions can result from blits, so handle them rather than
    crash. Only works for 2D textures (not even 2D array texture) due to a
    register allocation constraint that may not be sorted for a while.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ac42f2b3882e9425c372f952cc32b395c6a7c3b
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Jun 21 13:59:51 2019 -0700

    panfrost: Skip flushes only for wallpapers, not any blit
    
    We need the flush from u_blitter for a normal blit (e.g. for mipmaps);
    it's only wallpaper-related blits that are special-cased.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ffcc4d1c4e872b3bb5be1d6952e527e5c091370c
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Jun 21 13:57:42 2019 -0700

    panfrost: Handle generate_mipmap ourselves
    
    To avoid interference with the wallpaper code, we need to do some state
    tracking when generating mipmaps. In particular, we need to mark the
    generated layers as invalid before generating the mipmap, so we don't
    try to backblit them if they already had content.
    
    Likewise, we need to flush both before and after generating a mipmap
    since our usual set_framebuffer_state flushing isn't quite there yet.
    Ideally better optimizations would save the flush but I digress.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f57dfe4cdd7a51aa814a0533b30fc22db0357bcc
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Jun 21 16:58:48 2019 -0700

    panfrost: Disable mipmapping if necessary
    
    If a mipfilter is not set, it's legal to have an incomplete mipmap; we
    should handle this accordingly. An "easy way out" is to rig the LOD
    clamps.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>