Mesa (master): iris: Properly align interface descriptor data addresses

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jun 27 15:51:13 UTC 2019


Module: Mesa
Branch: master
Commit: f94ebf0c9db8dcd2257fd7eb20d457caad3bdeef
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f94ebf0c9db8dcd2257fd7eb20d457caad3bdeef

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Wed Jun 26 17:35:45 2019 -0700

iris: Properly align interface descriptor data addresses

MEDIA_INTERFACE_DESCRIPTOR's Interface Descriptor Data Start Address
field's docs say: "This bit specifies the 64-byte aligned address..."

And we were doing 32.  Superfluous thread ID uploading was apparently
saving us from GPU hangs in most cases.

---

 src/gallium/drivers/iris/iris_state.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/iris/iris_state.c b/src/gallium/drivers/iris/iris_state.c
index bf31f31f3e4..80c574845b0 100644
--- a/src/gallium/drivers/iris/iris_state.c
+++ b/src/gallium/drivers/iris/iris_state.c
@@ -5567,7 +5567,7 @@ iris_upload_compute_state(struct iris_context *ice,
             GENX(INTERFACE_DESCRIPTOR_DATA_length) * sizeof(uint32_t);
          load.InterfaceDescriptorDataStartAddress =
             emit_state(batch, ice->state.dynamic_uploader,
-                       &desc_res, desc, sizeof(desc), 32);
+                       &desc_res, desc, sizeof(desc), 64);
       }
 
       pipe_resource_reference(&desc_res, NULL);




More information about the mesa-commit mailing list