Mesa (master): panfrost/midgard: Don't force constant on VLUT

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Mar 4 05:05:26 UTC 2019


Module: Mesa
Branch: master
Commit: 4f7460297bcb07605f05e91236346aeedd0f0c16
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f7460297bcb07605f05e91236346aeedd0f0c16

Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Wed Feb 27 02:06:29 2019 +0000

panfrost/midgard: Don't force constant on VLUT

Previously, we forced a #0 inline constant tacked on for the lut
instructions to mirror the blob's behaviour, which caused some
suboptimal codegen due to our constant inlining implementation. Instead,
just don't force a constant at all.

Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Tested-by: Tomeu Vizoso <tomeu.vizoso at collabora.com

---

 src/gallium/drivers/panfrost/midgard/midgard_compile.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
index 65822d3b28f..f533572c05d 100644
--- a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
+++ b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
@@ -1069,7 +1069,6 @@ emit_alu(compiler_context *ctx, nir_alu_instr *instr)
                         .src0 = quirk_flipped_r24 ? SSA_UNUSED_1 : src0,
                         .src1 = quirk_flipped_r24 ? src0         : src1,
                         .dest = dest,
-                        .inline_constant = (nr_inputs == 1) && !quirk_flipped_r24
                 }
         };
 




More information about the mesa-commit mailing list