Mesa (master): svga: silence array out of bounds warning

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Mar 4 18:49:17 UTC 2019


Module: Mesa
Branch: master
Commit: 66ba12973bcbe35f7c41c32270f92073e946b1d5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=66ba12973bcbe35f7c41c32270f92073e946b1d5

Author: Brian Paul <brianp at vmware.com>
Date:   Fri Mar  1 13:56:18 2019 -0700

svga: silence array out of bounds warning

MinGW release build complains about a possible out-of-bounds
array access.  Test i < 4 to silence it.

Reviewed-by: Neha Bhende <bhenden at vmware.com>
Reviewed-by: Mathias Fröhlich <Mathias.Froehlich at web.de>

---

 src/gallium/drivers/svga/svga_tgsi_insn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/svga/svga_tgsi_insn.c b/src/gallium/drivers/svga/svga_tgsi_insn.c
index c7804b2680f..1392a3cc91f 100644
--- a/src/gallium/drivers/svga/svga_tgsi_insn.c
+++ b/src/gallium/drivers/svga/svga_tgsi_insn.c
@@ -2951,7 +2951,7 @@ svga_emit_immediate(struct svga_shader_emitter *emit,
    unsigned i;
 
    assert(1 <= imm->Immediate.NrTokens && imm->Immediate.NrTokens <= 5);
-   for (i = 0; i < imm->Immediate.NrTokens - 1; i++) {
+   for (i = 0; i < 4 && i < imm->Immediate.NrTokens - 1; i++) {
       float f = imm->u[i].Float;
       value[i] = util_is_inf_or_nan(f) ? 0.0f : f;
    }




More information about the mesa-commit mailing list