Mesa (master): spirv: OpImageQueryLod requires a sampler

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Mar 4 23:57:32 UTC 2019


Module: Mesa
Branch: master
Commit: ca295ddbfb414a526d3bab7daf93fffbbc417c6e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ca295ddbfb414a526d3bab7daf93fffbbc417c6e

Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Wed Feb 27 00:12:01 2019 -0600

spirv: OpImageQueryLod requires a sampler

No idea how this fell through the cracks besides the fact that the
sampler bound at 0 almost always works and the CTS isn't amazing.  In
any case, this appears to have been broken for almost forever.

Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable at lists.freedesktop.org

---

 src/compiler/spirv/spirv_to_nir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c
index f5511587be8..de5e6cc8659 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -2154,6 +2154,7 @@ vtn_handle_texture(struct vtn_builder *b, SpvOp opcode,
    case nir_texop_txl:
    case nir_texop_txd:
    case nir_texop_tg4:
+   case nir_texop_lod:
       /* These operations require a sampler */
       p->src = nir_src_for_ssa(&sampler->dest.ssa);
       p->src_type = nir_tex_src_sampler_deref;
@@ -2162,7 +2163,6 @@ vtn_handle_texture(struct vtn_builder *b, SpvOp opcode,
    case nir_texop_txf:
    case nir_texop_txf_ms:
    case nir_texop_txs:
-   case nir_texop_lod:
    case nir_texop_query_levels:
    case nir_texop_texture_samples:
    case nir_texop_samples_identical:




More information about the mesa-commit mailing list