Mesa (master): nir: Improve printing of load_input/store_output variable names.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Mar 5 19:08:33 UTC 2019


Module: Mesa
Branch: master
Commit: a4f612b4cf84cb5f40ab7eda6075dff89c2b6404
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a4f612b4cf84cb5f40ab7eda6075dff89c2b6404

Author: Eric Anholt <eric at anholt.net>
Date:   Sat Feb 23 16:17:02 2019 -0800

nir: Improve printing of load_input/store_output variable names.

We were printing only when the channel was exactly the start channel, so
scalarized loads/stores would be missing the name on the rest.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

---

 src/compiler/nir/nir_print.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c
index 80bc25fde9a..6b270394f9d 100644
--- a/src/compiler/nir/nir_print.c
+++ b/src/compiler/nir/nir_print.c
@@ -850,8 +850,10 @@ print_intrinsic_instr(nir_intrinsic_instr *instr, print_state *state)
    nir_foreach_variable(var, var_list) {
       if ((var->data.driver_location == nir_intrinsic_base(instr)) &&
           (instr->intrinsic == nir_intrinsic_load_uniform ||
-           var->data.location_frac == nir_intrinsic_component(instr)) &&
-          var->name) {
+           (nir_intrinsic_component(instr) >= var->data.location_frac  &&
+            nir_intrinsic_component(instr) <
+            (var->data.location_frac + glsl_get_components(var->type)))) &&
+           var->name) {
          fprintf(fp, "\t/* %s */", var->name);
          break;
       }




More information about the mesa-commit mailing list