Mesa (master): tgsi_to_nir: Fix TGSI LIT translation by using flt.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Mar 5 19:14:04 UTC 2019
Module: Mesa
Branch: master
Commit: fa076acbc097b9251044f7419760b1d4be56992c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fa076acbc097b9251044f7419760b1d4be56992c
Author: Timur Kristóf <timur.kristof at gmail.com>
Date: Thu Feb 14 00:45:47 2019 +0200
tgsi_to_nir: Fix TGSI LIT translation by using flt.
TGSI spec says LIT needs a "greater than" comparison. NIR doesn't have that,
so let's use "less than" and swap the arguments. Previously "greater than or equal"
was used by tgsi_to_nir which is incorrect.
Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
Tested-by: Andre Heider <a.heider at gmail.com>
Tested-by: Rob Clark <robdclark at gmail.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
---
src/gallium/auxiliary/nir/tgsi_to_nir.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c
index b35950289b9..545051e84ff 100644
--- a/src/gallium/auxiliary/nir/tgsi_to_nir.c
+++ b/src/gallium/auxiliary/nir/tgsi_to_nir.c
@@ -858,9 +858,9 @@ ttn_lit(nir_builder *b, nir_op op, nir_alu_dest dest, nir_ssa_def **src)
ttn_move_dest_masked(b, dest,
nir_bcsel(b,
- nir_fge(b,
- nir_imm_float(b, 0.0),
- ttn_channel(b, src[0], X)),
+ nir_flt(b,
+ ttn_channel(b, src[0], X),
+ nir_imm_float(b, 0.0)),
nir_imm_float(b, 0.0),
pow),
TGSI_WRITEMASK_Z);
More information about the mesa-commit
mailing list