Mesa (master): intel/nir: Drop an unneeded lower_constant_initializers call

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Mar 6 17:25:14 UTC 2019


Module: Mesa
Branch: master
Commit: 8993e0973f7d0cfb211e0c39de82ef2497584df3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8993e0973f7d0cfb211e0c39de82ef2497584df3

Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Mon Mar  4 16:01:23 2019 -0600

intel/nir: Drop an unneeded lower_constant_initializers call

Even though this is technically a step in the function inlining process
as laid out in nir_inline_functions.c, it's not really needed.  We
already have constant initializers lowered here and no new ones are
added by appending the softfp64 functions.

Reviewed-by: Matt Turner <mattst88 at gmail.com>
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/intel/compiler/brw_nir.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c
index 07e9ccc8388..58b89a1bd3c 100644
--- a/src/intel/compiler/brw_nir.c
+++ b/src/intel/compiler/brw_nir.c
@@ -700,8 +700,6 @@ brw_preprocess_nir(const struct brw_compiler *compiler, nir_shader *nir)
    }
    assert(exec_list_length(&nir->functions) == 1);
 
-   OPT(nir_lower_constant_initializers, ~nir_var_function_temp);
-
    if (nir->info.stage == MESA_SHADER_GEOMETRY)
       OPT(nir_lower_gs_intrinsics);
 




More information about the mesa-commit mailing list