Mesa (master): nir/algebraic: Remove redundant extract_[iu]8 patterns

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: 9aaaac60808e54b1ecb5887d082a53e50c59f63a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9aaaac60808e54b1ecb5887d082a53e50c59f63a

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Wed Feb 27 20:08:38 2019 -0800

nir/algebraic: Remove redundant extract_[iu]8 patterns

No shader-db changes on any Intel platform.

Reviewed-by: Matt Turner <mattst88 at gmail.com>
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
Acked-by: Jason Ekstrand <jason at jlekstrand.net>

---

 src/compiler/nir/nir_opt_algebraic.py | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py
index ac6e5b99220..f96c0182a29 100644
--- a/src/compiler/nir/nir_opt_algebraic.py
+++ b/src/compiler/nir/nir_opt_algebraic.py
@@ -604,22 +604,13 @@ optimizations = [
                            ('unpack_64_2x32_split_y', a)), a),
 
    # Byte extraction
-   (('ushr', ('ishl', 'a at 32', 24), 24), ('extract_u8', a, 0), '!options->lower_extract_byte'),
-   (('ushr', ('ishl', 'a at 32', 16), 24), ('extract_u8', a, 1), '!options->lower_extract_byte'),
-   (('ushr', ('ishl', 'a at 32', 8), 24), ('extract_u8', a, 2), '!options->lower_extract_byte'),
    (('ushr', 'a at 32', 24), ('extract_u8', a, 3), '!options->lower_extract_byte'),
-   (('ishr', ('ishl', 'a at 32', 24), 24), ('extract_i8', a, 0), '!options->lower_extract_byte'),
-   (('ishr', ('ishl', 'a at 32', 16), 24), ('extract_i8', a, 1), '!options->lower_extract_byte'),
-   (('ishr', ('ishl', 'a at 32', 8), 24), ('extract_i8', a, 2), '!options->lower_extract_byte'),
    (('ishr', 'a at 32', 24), ('extract_i8', a, 3), '!options->lower_extract_byte'),
-   (('iand', 0xff, ('ushr', a, 16)), ('extract_u8', a, 2), '!options->lower_extract_byte'),
-   (('iand', 0xff, ('ushr', a,  8)), ('extract_u8', a, 1), '!options->lower_extract_byte'),
    (('iand', 0xff, a), ('extract_u8', a, 0), '!options->lower_extract_byte')
 ]
 
-# The ('extract_u8', a, 0) pattern, above, can trigger in cases where the
-# shift count is based on a loop induction variable.  Once the loop is
-# unrolled, constant folding will generate patterns like those below.
+# After the ('extract_u8', a, 0) pattern, above, triggers, there will be
+# patterns like those below.
 for op in ('ushr', 'ishr'):
    optimizations.extend([(('extract_u8', (op, 'a at 16',  8),     0), ('extract_u8', a, 1))])
    optimizations.extend([(('extract_u8', (op, 'a at 32',  8 * i), 0), ('extract_u8', a, i)) for i in range(1, 4)])
@@ -627,9 +618,8 @@ for op in ('ushr', 'ishr'):
 
 optimizations.extend([(('extract_u8', ('extract_u16', a, 1), 0), ('extract_u8', a, 2))])
 
-# The ('extract_[iu]8', a, 3) patterns, above, can trigger in cases where the
-# shift count is based on a loop induction variable.  Once the loop is
-# unrolled, constant folding will generate patterns like those below.
+# After the ('extract_[iu]8', a, 3) patterns, above, trigger, there will be
+# patterns like those below.
 for op in ('extract_u8', 'extract_i8'):
    optimizations.extend([((op, ('ishl', 'a at 32', 24 - 8 * i), 3), ('extract_u8', a, i)) for i in range(2, -1, -1)])