Mesa (master): anv: release memory allocated by bo_heap when descriptor pool is destroyed

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Mar 11 06:16:45 UTC 2019


Module: Mesa
Branch: master
Commit: 7bb34ecff9833e0b490e90ab04fdaa6342eadc1b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7bb34ecff9833e0b490e90ab04fdaa6342eadc1b

Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Fri Mar  8 10:29:26 2019 +0200

anv: release memory allocated by bo_heap when descriptor pool is destroyed

Fixes following leak:

   ==21853== 32 bytes in 1 blocks are definitely lost in loss record 2 of 20
   ==21853==    at 0x483AB1A: calloc (vg_replace_malloc.c:762)
   ==21853==    by 0x4C4DD7F: util_vma_heap_free (vma.c:221)
   ==21853==    by 0x4C4D647: util_vma_heap_init (vma.c:46)
   ==21853==    by 0x4957B9F: anv_CreateDescriptorPool (anv_descriptor_set.c:578)

Fixes: c520f4dec9cb ("anv: Add a concept of a descriptor buffer")
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

---

 src/intel/vulkan/anv_descriptor_set.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c
index 75ab643f475..f293cf469ee 100644
--- a/src/intel/vulkan/anv_descriptor_set.c
+++ b/src/intel/vulkan/anv_descriptor_set.c
@@ -614,6 +614,8 @@ void anv_DestroyDescriptorPool(
       anv_descriptor_set_destroy(device, pool, set);
    }
 
+   util_vma_heap_finish(&pool->bo_heap);
+
    vk_free2(&device->alloc, pAllocator, pool);
 }
 




More information about the mesa-commit mailing list