Mesa (master): v3d: Fix leak of the mem_ctx after the DAG refactor.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Mar 12 23:43:50 UTC 2019


Module: Mesa
Branch: master
Commit: 0c874c18cd07539f56fede272a24b76f2946716f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0c874c18cd07539f56fede272a24b76f2946716f

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Mar 12 14:56:57 2019 -0700

v3d: Fix leak of the mem_ctx after the DAG refactor.

Noticed while trying to get a CTS run again.

Fixes: 33886474d646 ("v3d: Use the DAG datastructure for QPU instruction scheduling.")

---

 src/broadcom/compiler/qpu_schedule.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/broadcom/compiler/qpu_schedule.c b/src/broadcom/compiler/qpu_schedule.c
index c7c12063816..d275940c136 100644
--- a/src/broadcom/compiler/qpu_schedule.c
+++ b/src/broadcom/compiler/qpu_schedule.c
@@ -1338,7 +1338,7 @@ qpu_schedule_instructions_block(struct v3d_compile *c,
                                 uint32_t *next_uniform)
 {
         void *mem_ctx = ralloc_context(NULL);
-        scoreboard->dag = dag_create(NULL);
+        scoreboard->dag = dag_create(mem_ctx);
         struct list_head setup_list;
 
         list_inithead(&setup_list);
@@ -1366,7 +1366,7 @@ qpu_schedule_instructions_block(struct v3d_compile *c,
                                                 orig_uniform_data,
                                                 next_uniform);
 
-        ralloc_free(scoreboard->dag);
+        ralloc_free(mem_ctx);
         scoreboard->dag = NULL;
 
         return cycles;




More information about the mesa-commit mailing list