Mesa (18.3): 66 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Mar 15 14:54:27 UTC 2019
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=60fb5f4b8677ad316feb1d949617b119392b1a2e
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Mar 14 14:27:03 2019 +0100
radv: always initialize HTILE when the src layout is UNDEFINED
HTILE should always be initialized when transitioning from
VK_IMAGE_LAYOUT_UNDEFINED to other image layouts. Otherwise,
if an app does a transition from UNDEFINED to GENERAL, the
driver doesn't initialize HTILE and it tries to decompress
the depth surface. For some reasons, this results in VM faults.
Cc: mesa-stable at lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107563
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 3a2e93147f7fa4a6fd17313353113a33291c5ce0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bdd5f24c1b1bd94b8725263cf287c5987fe7229a
Author: Kevin Strasser <kevin.strasser at intel.com>
Date: Mon Jan 28 10:42:44 2019 -0800
egl/dri: Avoid out of bounds array access
indexConfigAttrib iterates over every index in the dri driver, possibly
exceeding __DRI_ATTRIB_MAX. In other words, if the dri driver has newer
attributes libEGL will end up reading from uninitialized memory through
dri2_to_egl_attribute_map[].
Signed-off-by: Kevin Strasser <kevin.strasser at intel.com>
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit 70b36c0ef939048acb9c4727b2e4280fc090eb74)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f30487a80194b80af2670b4e7da751d383678d3
Author: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Date: Wed Jan 2 15:55:08 2019 +0200
glsl/linker: Fix unmatched TCS outputs being reduced to local variable
Always match TCS outputs since they are shared by all invocations
within the patch and should not be converted to local variables.
This is one of the issues found in Downward.
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104297
(cherry picked from commit 9f29d90327e343f5717a98ceb6df2cdbab5d0e0b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a1c6be2ab64b3c9617e91444287ef913a8cc5609
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Mon Mar 11 19:00:21 2019 -0700
intel/fs: Fix opt_peephole_csel to not throw away saturates.
We were not copying the saturate bit from the original instruction
to the new replacement instruction. This caused major misrendering
in DiRT Rally on iris, where comparisons leading to discards failed
due to the missing saturate, causing lots of extra garbage pixels to
be drawn in text rendering, trees, and so on.
This did not show up on i965 because st/nir performs a more aggressive
version of nir_opt_peephole_select, yielding more b32csel operations.
Fixes: 52c7df1643e i965/fs: Merge CMP and SEL into CSEL on Gen8+
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
(cherry picked from commit 3570d15b6d88bdcd353b31ffe5460d04a88b7b6f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=92ad8814ac350019f71a21db54e2b264b8a7766d
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Mon Mar 11 20:43:15 2019 -0500
glsl/lower_vector_derefs: Don't use a temporary for TCS outputs
Tessellation control shader outputs act as if they have memory backing
them and you can have multiple writes to different components of the
same vector in-flight at the same time. When this happens, the load vec
store pattern that gets used by ir_triop_vector_insert doesn't yield the
correct results. Instead, just emit a sequence of conditional
assignments.
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Cc: mesa-stable at lists.freedesktop.org
(cherry picked from commit bd17bdc56b34a08c421172df27fe07294c7a7024)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=612ddf210ff8fb4c7186c3951a344f6aa01b778c
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Mon Mar 11 21:01:34 2019 -0500
glsl/list: Add a list variant of insert_after
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
(cherry picked from commit 20c4578c5539de909e94a6acc3ad680ab2ddeca6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b6cf9b73482e23e0d528396dfa367a8fceb290f1
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Wed Mar 13 17:47:20 2019 +0000
cherry-ignore: add explicit 19.0 performance optimisations
nir: lower IO to vector
intel: make use of the optimisation
They address a 10% regression in a synthetic benchmark. No real world
use-cases seems to be affected.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=13b23099a36769c30b8bc4bbefec3b7b01350a65
Author: pal1000 <liviuprodea at yahoo.com>
Date: Thu Mar 7 10:38:10 2019 +0200
scons: Compatibility with Scons development version string
This ensures Mesa3D build doesn't fail in this case as encountered when
bisecting Scons source code while regression testing
https://bugs.freedesktop.org/show_bug.cgi?id=109443
and when testing 3.0.5.a.2
Technical details:
Scons version string has consistently been in this format:
MajorVersion.MinorVersion.Patch[.alpha/beta.yyyymmdd]
so these formulas should strip alpha/beta flags and return Scons version:
- as string - `'.'.join(SCons.__version__.split('.')[:3])`
- as tuple of integers - `tuple(map(int, SCons.__version__.split('.')[:3]))`
- v2: Fixed Scons version retrieval formulas as string and tuple of integers.
- v3: Fixed Scons version string format description.
Cc: "19.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
(cherry picked from commit 7f89fd17ed2b1bd0c0fe4ec946dcabed0f8c74d3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dea94622fb16f926cd7becf9066febaf1f6f64f3
Author: Jose Fonseca <jfonseca at vmware.com>
Date: Thu Feb 28 09:53:28 2019 +0000
scons: Workaround failures with MSVC when using SCons 3.0.[2-4].
This change applies the workaround suggested by Bill Deegan on the
affected SCons versions.
It also adds a comment with the URL explaining why we were using
customizing the decider and max_drift in the first place, as I had
forgotten all about it.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109443
Tested-by: liviuprodea at yahoo.com
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Reviewed-by: Brian Paul <brianp at vmware.com>
(cherry picked from commit 838c0485e01f3d3403b430aa6df5b4a1f5262dc3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce57ea90d3129f00f89be0e9171630ea8eeb79f2
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Mar 11 10:25:53 2019 +0100
radv: fix pointSizeRange limits
The values should match the ones that are emitted.
This fixes new CTS dEQP-VK.rasterization.primitive_size.points.*.
Fixes: f4e499ec791 ("radv: add initial non-conformant radv vulkan driver")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 6403171843824ec8e9484bb8a21a4a18bfb01193)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d88857823f0f18020f1005b3e8c8a3271ba71f53
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date: Mon Mar 11 18:33:54 2019 +0100
anv: destroy descriptor sets when pool gets reset
As stated in Vulkan spec:
"Resetting a descriptor pool recycles all of the resources from all
of the descriptor sets allocated from the descriptor pool back to
the descriptor pool, and the descriptor sets are implicitly freed."
This fixes dEQP-VK.api.descriptor_pool.*
Fixes: 14f6275c92f1 "anv/descriptor_set: add reference counting for..."
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Tested-by: Clayton Craft <clayton.a.craft at intel.com>
(cherry picked from commit 775aabdd01739c413da7b38e5acbde1094209bcf)
Squashed with:
anv: Fix destroying descriptor sets when pool gets reset
pool->next and pool->free_list were reset before their usage in
anv_descriptor_pool_free_set
Fixes: 775aabdd "anv: destroy descriptor sets when pool gets reset"
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
(cherry picked from commit 9c80be956fff4d4786a9b77c6b9d3fec67ff2377)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dfcae38dcc65de76a828c7a1e31b0789f5c7016b
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Wed Mar 13 18:14:45 2019 +0000
cherry-ignore: ignore glsl_types memory cleanup patch
The commit was reverted shortly after it was applied on master
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=81107c96e600277ac0db8216d99c2ec1b7699642
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Mon Mar 4 14:22:36 2019 +0200
anv: destroy descriptor sets when pool gets destroyed
Patch maintains a list of sets in the pool and destroys possible
remaining sets when pool is destroyed.
As stated in Vulkan spec:
"When a pool is destroyed, all descriptor sets allocated from
the pool are implicitly freed and become invalid."
This fixes memory leaks spotted with valgrind:
==19622== 96 bytes in 1 blocks are definitely lost in loss record 2 of 3
==19622== at 0x483880B: malloc (vg_replace_malloc.c:309)
==19622== by 0x495B67E: default_alloc_func (anv_device.c:547)
==19622== by 0x4955E05: vk_alloc (vk_alloc.h:36)
==19622== by 0x4956A8F: anv_multialloc_alloc (anv_private.h:538)
==19622== by 0x4956A8F: anv_CreateDescriptorSetLayout (anv_descriptor_set.c:217)
Fixes: 14f6275c92f1 ("anv/descriptor_set: add reference counting for descriptor set layouts")
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 105002bd2d6173b24f6955c22340b5bc77e029fa)
[Emil: move list_del() anv_descriptor_{pool_free_set,set_destroy} ]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Conflicts:
src/intel/vulkan/anv_descriptor_set.c
---
Mostly a gut feeling - Tapani do we need a list_addtail/list_del in
anv_descriptor_set_create()?
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5429dd0098c21f0487420433025d30651c59830c
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Wed Mar 13 15:37:45 2019 +0000
cherry-ignore: add gitlab-ci fixup commit
gitlab-ci: autotools needs to be told which llvm version to use
Commit references invalid sha - the offender did not land in branch.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b638eb5db420fcc489abb652f147cf7390605325
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Wed Feb 27 15:53:55 2019 -0800
intel/fs: Fix extract_u8 of an odd byte from a 64-bit integer
In the old code, we would generate the exact same instruction for
extract_u8(some_u64, 0) and extract_u8(some_u64, 1). The mask-a-word
trick only works for even numbered bytes.
This fixes the (new) piglit test
tests/spec/arb_gpu_shader_int64/execution/fs-ushr-and-mask.shader_test.
v2: Use a SHR instead of an AND. This saves an instruction compared to
using two moves. Suggested by Jason.
Fixes: 6ac2d169019 ("i965/fs: Fix extract_i8/u8 to a 64-bit destination")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 55e6454d5e9dae6f8f29992af83f99217446da38)
[Emil: byte -> byte->u32[0] ]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8448ece46090c1b387640b244959f1d45b23a764
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Wed Feb 27 15:52:18 2019 -0800
intel/fs: nir_op_extract_i8 extracts a byte, not a word
Fixes: 6ac2d169019 ("i965/fs: Fix extract_i8/u8 to a 64-bit destination")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 4aaf139ea4cc7c4703e1906e0074f87f76c8e4cc)
[Emil: resolve trivial conflicts]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Conflicts:
src/intel/compiler/brw_fs_nir.cpp
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f7c54eccec76d80a496d019335415423b32a9ca
Author: Marek Olšák <marek.olsak at amd.com>
Date: Fri Jan 11 18:06:59 2019 -0500
radeonsi: compile clear and copy buffer compute shaders on demand
same as all other shaders
(cherry picked from commit c605738113fe91d04f799eae52cec28fafac3f2d)
Bug: https://github.com/ValveSoftware/halflife/issues/2100
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=89f3547656d583c77df38ac5166791ac4d858e1c
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Wed Mar 6 21:45:12 2019 +0000
cherry-ignore: add 19.0 only anv/push buffer nominations
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4b372644f35dd2f91fd46b029813be481ae6d3f0
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Sat Jan 12 10:32:13 2019 -0600
spirv: Pull offset/stride from the pointer for OpArrayLength
We can't pull it from the variable type because it might be an array of
blocks and not just the one block. While we're here, throw in some
error checking.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable at lists.freedesktop.org
(cherry picked from commit f1dbc7e97d3dcb2104b9438d32cace9529575208)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=079c124bcbc9231ef2c5bd9b465f0241902412cd
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Mar 4 14:25:08 2019 +0100
radv: properly align the fence and EOP bug VA on GFX9
If alignement is 0, offets returned by
radv_cmd_buffer_upload_alloc() are always 0. These two
virtual addresses were pointing at the same location.
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit c2a148692b4d728e481b60a503e21931f9cf43f0)
[Emil: resolve trivial conflicts]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Conflicts:
src/amd/vulkan/radv_cmd_buffer.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=238c8c042b838a0df3c00c1a9fcde4d182b3e901
Author: Eric Engestrom <eric.engestrom at intel.com>
Date: Wed Feb 27 15:26:08 2019 +0000
egl: fix libdrm-less builds
This function was never used, and isn't properly guarded by HAVE_LIBDRM,
breaking the build on systems that don't have libdrm.
Let's just remove it.
Fixes: 7552fcb7b9b98392e6a8 "egl: add base EGL_EXT_device_base implementation"
Reported-by: Timo Aaltonen <tjaalton at debian.org>
Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
Acked-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit bcc4bfc8e80da5dc4c6ee44f791f2112dac208d1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c590c067765cd1c37462f9d7e9793f94b7c60540
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Wed Feb 20 09:18:39 2019 +0200
anv: retain the is_array state in create_plane_tex_instr_implicit
This does not seem to fix anything ATM but is the right thing todo.
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Fixes: f3e91e78a33775 ("anv: add nir lowering pass for ycbcr textures")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
(cherry picked from commit 33bf3d510c98a22706eb25815f1214d2e1a0e868)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8d21a1f8143adf46cc65df9b620deab0dd9cfad2
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Wed Feb 27 00:12:01 2019 -0600
spirv: OpImageQueryLod requires a sampler
No idea how this fell through the cracks besides the fact that the
sampler bound at 0 almost always works and the CTS isn't amazing. In
any case, this appears to have been broken for almost forever.
Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable at lists.freedesktop.org
(cherry picked from commit ca295ddbfb414a526d3bab7daf93fffbbc417c6e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=85b165e99c11202d8731fa9216cee226bc20d04a
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Fri Mar 1 14:01:08 2019 -0600
anv: Count surfaces for non-YCbCr images in GetDescriptorSetLayoutSupport
We were accidentally not counting those surfaces
Fixes: ddc4069122 "anv: Implement VK_KHR_maintenance3"
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
(cherry picked from commit 5049fbddb4687799a10eb585c8789afa0d080535)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dd2554c85b7f0254d40fdbac905624bef8ec83bc
Author: Axel Davy <davyaxel0 at gmail.com>
Date: Fri Feb 22 20:45:51 2019 +0100
st/nine: Ignore multisample quality level if no ms
Apparently instead of returning error when passing
a quality level different than 0 for
D3DMULTISAMPLE_NONE, we should pass.
Fixes: https://github.com/iXit/Mesa-3D/issues/340
Cc: mesa-stable at lists.freedesktop.org
Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
(cherry picked from commit 1d363d440f261fbadc1db3c17acc514b7130d505)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b1ef1c7a8e13308bce634cd2f93fe270b5de10fb
Author: Axel Davy <davyaxel0 at gmail.com>
Date: Wed Jan 2 22:13:12 2019 +0100
st/nine: Ignore window size if error
Check GetWindowInfo and ignore the computed sizes
if there is an error.
Fixes a regression caused by earlier commit when
using old wine gallium nine patches.
Should also address a crash at window destruction.
Related issues:
https://github.com/iXit/Mesa-3D/issues/331
https://github.com/iXit/Mesa-3D/issues/332
Cc: mesa-stable at lists.freedesktop.org
Fixes: 2318ca68bbe ("st/nine: Handle window resize when a presentation buffer is used")
Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
(cherry picked from commit 86666f051e0cae96f2596cac05e3c3f394744149)
[Emil: resolve trivial conflicts]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Conflicts:
src/gallium/state_trackers/nine/swapchain9.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a61b6345764974df861a4dd8df122ce7e64d780f
Author: Mauro Rossi <issor.oruam at gmail.com>
Date: Sat Mar 2 23:38:27 2019 +0100
android: anv: fix libexpat shared dependency
Fixes undefined reference building errors for XML_* functions
Signed-off-by: Mauro Rossi <issor.oruam at gmail.com>
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
Cc: "19.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit ec0f465bc5f02c93aeb4193db8b5bd90a254b080)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9814e187008cc7aa152ab52a45b02b35d6af5396
Author: Mauro Rossi <issor.oruam at gmail.com>
Date: Mon Mar 4 10:34:08 2019 +0100
android: anv: fix generated files depedencies (v2)
Fix anv_extrypoints.{c,h} and anv_extensions.{c,h} missing dependencies
Rename the variable labels according to targets and python scripts
Align the building rules as per Automake for simplification
Fixes building errors during rebuils due to missing dependencies
(v2) Fixed a missing $(VULKAN_API_XML) reference
Fixes: 9a508b7 ("android: anv/extensions: fix generated sources build")
Fixes: dd088d4bec7 ("anv/extensions: Generate a header file with extension tables")
Signed-off-by: Mauro Rossi <issor.oruam at gmail.com>
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Cc: "19.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 14e7e26a0991e7f9b1d20147f04a43bb4cc3f824)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ea63096528e28192843321be5a1b640cadbd9ee
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Fri Feb 22 01:13:39 2019 -0500
glsl: fix recording of variables for XFB in TCS shaders
This is purely for conformance, since it's not actually possible to do
XFB on TCS output varyings. However we do have to make sure we record
the names correctly, and this removes an extra level of array-ness from
the names in question.
Fixes KHR-GL45.tessellation_shader.single.xfb_captures_data_from_correct_stage
v2: Add comment to the new program_resource_visitor::process function.
(Ilia Mirkin)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108457
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Cc: 19.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit 4eec3a2a3652317f8e0fa97e0730c297bde8241a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0d0d6f43693014b4507ca07864d0bc6f027b43bb
Author: Jose Maria Casanova Crespo <jmcasanova at igalia.com>
Date: Wed Nov 21 18:23:03 2018 +0100
glsl: TCS outputs can not be transform feedback candidates on GLES
Avoids regression on:
KHR-GLES*.core.tessellation_shader.single.xfb_captures_data_from_correct_stage
that is uncovered by the following patch.
"glsl: fix recording of variables for XFB in TCS shaders"
v2: Rebased over glsl: fix recording of variables for XFB in TCS shaders
v3: Move this patch before "glsl: fix recording of variables for XFB in TCS
shaders" to avoid temporal regressions. (Illia Mirkin)
Cc: 19.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit bf1f49482d677e562993543cd9a9367597ce3ccc)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7c3c0823bafffdc725a2651d8b55ac32acf355da
Author: Ray Zhang <zhanglei002 at gmail.com>
Date: Wed Feb 27 06:54:05 2019 +0000
glx: fix shared memory leak in X11
call XShmDetach to allow X server to free shared memory
Fixes: bcd80be49a8260c2233d "drisw/glx: use XShm if possible"
Signed-off-by: Ray Zhang <zhanglei002 at gmail.com>
Reviewed-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit b344e32cdf7064a1f2ff7ef37027edda6589404f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8919ea0672f61f6ad194af808a5b02eaf5de5b0d
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date: Wed Feb 27 18:26:07 2019 +1100
glsl: fix shader cache for packed param list
Some types of params such as some builtins are always padded. We
need to keep track of this so we can restore the list correctly.
Here we also remove a couple of cache entries that are not actually
required as they get rebuilt by the _mesa_add_parameter() calls.
This patch fixes a bunch of arb_texture_multisample and
arb_sample_shading piglit tests for the radeonsi NIR backend.
Fixes: edded1237607 ("mesa: rework ParameterList to allow packing")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 7536af670b7501228628a8c90f9e8456b5aec9e1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=24db6eeca135bfa72ace137c245c8c439ebc8cc2
Author: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
Date: Mon Feb 25 16:21:48 2019 +0200
i965: Fix allow_higher_compat_version workaround limited by OpenGL 3.0
Added check for higher compat profile being allowed
before assigning certain extensions.
Fixes: 272fe9494232 (mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile)
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107052
(cherry picked from commit 07f4b4e4034d6c9f48d136ec39a03e59f65783cb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5a7cad3d52cca0ed54dc408da5699373e04b53c9
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sat Feb 23 14:33:31 2019 +0100
radv: Interpolate less aggressively.
Seems like dxvk used integer builtins without setting the flat
interpolation decoration.
I believe in the current spec the app is required to set these,
but in the meantime to avoid breaking things in stable releases
(and so close to release for 19.0), only expand the interpolation
to float16 and struct (which cannot be builtins as our spirv parser
lowers the builtin block).
Fixes: f3247841040 "radv: Allow interpolation on non-float types."
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit c0110477b5503978adf37f64c65c30c9304e3fe4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6765cee986db8406d57ec81420c140c5a7937523
Author: Eleni Maria Stea <estea at igalia.com>
Date: Fri Feb 22 23:02:30 2019 +0200
i965: fixed clamping in set_scissor_bits when the y is flipped
Calculating the scissor rectangle fields with the y flipped (0 on top)
can generate negative values that will cause assertion failure later on
as the scissor fields are all unsigned. We must clamp the bbox values
again to make sure they don't exceed the fb_height. Also fixed a
calculation error.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108999
https://bugs.freedesktop.org/show_bug.cgi?id=109594
v2:
- I initially clamped the values inside the if (Y is flipped) case
and I made a mistake in the calculation: the clamp of the bbox[2] should
be a check if (bbox[2] >= fbheight) bbox[2] = fbheight - 1 instead and I
shouldn't have changed the ScissorRectangleYMax calculation. As the
fixed code is equivalent with using CLAMP instead of MAX2 at the top of
the function when bbox[2] and bbox[3] are calculated, and the 2nd is more
clear, I replaced it. (Nanley Chery)
v3:
- Reversed the CLAMP change in bbox[3] as the API guarantees that the
viewport height is positive. (Nanley Chery)
v4:
- Added nomination for the mesa-stable branch and the link to the second
bugzilla bug (Nanley Chery)
CC: <mesa-stable at lists.freedesktop.org>
Tested-by: Paul Chelombitko <qamonstergl at gmail.com>
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
(cherry picked from commit fd37a19ac4c8b2ebff330b2a06a7f311f7d478e3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=eb9912b5c7b365f64620bf36428349aa028e7044
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Feb 14 11:23:58 2019 +0000
meson: egl: correctly manage loader/xmlconfig
Earlier commit introduced support for haiku yet did not properly
annotate the loader/xmlconfig dependencies.
Thus we ended up adding inc_loader for each !haiku platform - see
659910eda01 9a96bf0ecd0 c731508b988 ec6cb01e216.
One piece remained though - the wayland platform. Hence the following
would fail:
meson -Dgallium-drivers=etnaviv -Ddri-drivers=''\
-Dtools=etnaviv -Dplatforms=wayland -Dglx=disabled \
build/
Cc: Alexander von Gluck IV <kallisti5 at unixzen.com>
Reported-by: Boris Brezillon <boris.brezillon at collabora.com>
Fixes: 834d221512f ("meson: Add Haiku platform support v4")
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Tested-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
(cherry picked from commit f0a7b463b5586972f4b7f5d9d84eb0564087ce3f)
[Emil: resolve trivial conflicts]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Conflicts:
src/egl/meson.build
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b79bac03c4926fc155752f50febeb60c5b668f60
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Feb 25 15:28:25 2019 +0100
radv: don't copy buffer descriptors list for samplers
Sampler descriptors don't have a buffer list.
This fixes some crashes with new CTS
dEQP-VK.binding_model.descriptor_copy.*.sampler_*.
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 4924dfc851e52c383380ae56be4d8606684ead7c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0a261496f87094b6dbe5f1f7bba2b8beff6a136d
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Feb 25 15:28:24 2019 +0100
radv: fix out-of-bounds access when copying descriptors BO list
We shouldn't increment the buffer list pointers twice.
This fixes some crashes with new CTS
dEQP-VK.binding_model.descriptor_copy.*.
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 9256e0a09dfa94fecfef8e250755732ac35689ec)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b72e2f860049ab0a7e2d77e6a7fcc361119da9a2
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Mon Feb 25 11:14:11 2019 +0200
nir: initialize value in copy_prop_vars_block
Fixes following valgrind warning:
==27561== Conditional jump or move depends on uninitialised value(s)
==27561== at 0x667856B: value_set_ssa_components (nir_opt_copy_prop_vars.c:78)
==27561== by 0x667A1C4: copy_prop_vars_block (nir_opt_copy_prop_vars.c:797)
Fixes: 62332d139c8 "nir: Add a local variable-based copy propagation pass"
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
(cherry picked from commit 22267feff1a35c4b6f1f0cb9c8e371727f99b5d6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3c4cc070c12ca8dcb287dcb10bff32ae19913d32
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Feb 25 12:14:59 2019 +0100
radv: fix clearing attachments in secondary command buffers
If no framebuffer is bound, get the number of samples and the
image format from the render pass.
This fixes new CTS dEQP-VK.geometry.layered.*.secondary_cmd_buffer.
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 5671f38085216caf2cbf221a9fcda08b7571a762)
[Emil: resolve trivial conflicts]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Conflicts:
src/amd/vulkan/radv_meta_clear.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1f09d08a4f19dcd5661e0abc2cb5ed424c954cac
Author: Sergii Romantsov <sergii.romantsov at globallogic.com>
Date: Fri Feb 22 11:23:08 2019 +0200
d3d: meson: do not prefix user provided d3d-drivers-path
The user can select the location where there d3d drivers
are installed by the d3d-drivers-path meson option.
By default path will be $prefix/$libdir/d3d.
Currently we add $prefix to the user provided path.
Resulting in an incorrect or even missing path.
Based on logic of
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109698
CC: Kenneth Graunke <kenneth at whitecape.org>
CC: Emil Velikov <emil.l.velikov at gmail.com>
Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit dcc48664197c7e44684ccfb970a4ae083974d145)
Fixes: b7c6870f87a ("meson: Add moduledir to d3d.pc")
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5ed1b33205bd5605b3e2a7b319aa47d6f7238dc1
Author: Sergii Romantsov <sergii.romantsov at globallogic.com>
Date: Thu Feb 21 10:28:11 2019 +0200
dri: meson: do not prefix user provided dri-drivers-path
The user can select the location where there dri drivers
are installed by the dri-drivers-path meson option.
By default path will be $prefix/$libdir/dri.
Currently we add $prefix to the user provided path.
Resulting in an incorrect or even missing path.
v2: fixed dri_search_path by default, rebased to master
v3: new commit-message (Emil Velikov), cc mesa-stable
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109698
CC: Rafael Antognolli <rafael.antognolli at intel.com>
CC: Dylan Baker <dylan at pnwbakers.com>
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Fixes: 306914db92e1 (meson: Add dridriverdir variable to dri.pc.)
Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit f6556ec7d126b31da37c08d7cb657250505e01a0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2f67fa564f407d84f1ef95a22090d826cd0d7c54
Author: David Shao <davshao at gmail.com>
Date: Sun Feb 24 09:00:36 2019 +0000
meson: ensure that xmlpool_options.h is generated for gallium targets that need it
Fixes: 68076b87474e7959c161 "meson: build gallium vdpau state tracker"
Fixes: 22a817af8a89eb3c762f "meson: build gallium xvmc state tracker"
Fixes: 5a785d51a6d68ec676ce "meson: build gallium va state tracker"
Fixes: 0ba909f0f111824223bc "meson: build gallium xa state tracker"
Fixes: 1d36dc674d528b93bec3 "meson: build gallium omx state tracker"
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
(cherry picked from commit 6fa923a65daf1ee73c5cc763ade91abc82da7085)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=09542cd07074574efd85a9c9dc25748fde2274b3
Author: Alok Hota <alok.hota at intel.com>
Date: Thu Feb 21 14:41:15 2019 -0600
swr/rast: bypass size limit for non-sampled textures
This fixes a bug where SWR will fail to render in cases with large
buffer allocations, e.g. very large meshes whose vertex buffers exceed
2GB
CC: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Bruce Cherniak <bruce.cherniak at intel.com>
(cherry picked from commit 6053499f2eafde606b13a9663016e9be8e4089eb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=483f947a58a72a9ac9e77ca1e2a276afe078733c
Author: Marek Olšák <marek.olsak at amd.com>
Date: Wed Feb 20 17:21:32 2019 -0500
tgsi: don't set tgsi_info::uses_bindless_images for constbufs and hw atomics
This might have decreased performance for radeonsi/tgsi, because most
most shaders claimed they used bindless.
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
(cherry picked from commit b326a15edab34d09e7b328dd8726137960ae12a5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e5bc47ca7d4793b096c644fb37b828854ca1943b
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date: Fri Feb 22 16:47:53 2019 +0100
anv: advertise 8 subpixel precision bits
On one side, when emitting 3DSTATE_SF, VertexSubPixelPrecisionSelect is
used to select between 8 bit subpixel precision (value 0) or 4 bit
subpixel precision (value 1). As this value is not set, means it is
taking the value 0, so 8 bit are used.
On the other side, in the Vulkan CTS tests, if the reference rasterizer,
which uses 8 bit precision, as it is used to check what should be the
expected value for the tests, is changed to use 4 bit as ANV was
advertising so far, some of the tests will fail.
So it seems ANV is actually using 8 bits.
v2: explicitly set 3DSTATE_SF::VertexSubPixelPrecisionSelect (Jason)
v3: use _8Bit definition as value (Jason)
v4: (by Jason)
anv: Explicitly set 3DSTATE_CLIP::VertexSubPixelPrecisionSelect
This field was added on gen8 even though there's an identically defined
one in 3DSTATE_SF.
CC: Jason Ekstrand <jason at jlekstrand.net>
CC: Kenneth Graunke <kenneth at whitecape.org>
CC: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 4f917e6a61860b58a05d40584f7aa3d5e4e32b75)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=da4db48c191dc8bdf929b47949e53e6fb3562e84
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date: Fri Feb 22 16:16:24 2019 +0100
genxml: add missing field values for 3DSTATE_SF
Fill out "Vertex Sub Pixel Precision Select" possible values.
CC: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 3b423eeb2d326418147fdfbdc89a415e44a557d3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d9d90ac6631324e891a2877adc6febe5f91ac218
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Fri Feb 22 14:24:28 2019 +0100
radv: Allow interpolation on non-float types.
In particular structs containing floats and 16-bit floating point
types.
Fixes: 62024fa7750 "radv: enable VK_KHR_16bit_storage extension / 16bit storage features"
Fixes: da295946361 "spirv: Only split blocks"
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109735
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit f3247841040a202faffe4709c07da9bd41693580)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e8d3c8458291e02459146bb458547baec93d2efe
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Fri Feb 22 14:16:08 2019 +0100
radv: Fix float16 interpolation set up.
float16 types can have non-flat interpolation so set up the HW
correctly for that.
Fixes: 62024fa7750 "radv: enable VK_KHR_16bit_storage extension / 16bit storage features"
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit a1fdd4a4a73604469b6204a56457b08f8ae4a948)
[Emil: resolve trivial conflicts]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Conflicts:
src/amd/vulkan/radv_nir_to_llvm.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bd00bd7c5967ed2bb93e485e8d0b4490fe949ae7
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Wed Feb 20 12:49:17 2019 +0000
intel: fix urb size for CFL GT1
Same 192Kb amount as SKL/KBL GT1 applies.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
Fixes: de7ed0ba5522 ("i965/CFL: Add PCI Ids for Coffee Lake.")
(cherry picked from commit 1d626fc02895daa9e7f7c74a829b9512f08869e8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d6a8802aa7fb43812e4424effa946bf61dc4725e
Author: Francisco Jerez <currojerez at riseup.net>
Date: Fri Jan 18 12:51:57 2019 -0800
intel/fs: Implement extended strides greater than 4 for IR source regions.
Strides up to 32B can be implemented for the source regions of most
instructions by leveraging either the vertical or the horizontal
stride of the hardware Align1 region. The main motivation for this is
that currently the lower_integer_multiplication() pass will happily
double the stride of one of the 32-bit sources, which can blow up if
the stride of the original source was already the maximum value
allowed by the hardware.
An alternative would be to use the regioning legalization pass in
order to lower such strides into the composition of multiple legal
strides, but that would be somewhat less efficient.
This showed up as a regression from my commit cbea91eb57a501bebb1ca2
in Vulkan 1.1 CTS tests on CHV/BXT platforms, however it was really a
pre-existing problem that had affected conformance on other platforms
without native support for integer multiplication. CHV/BXT were
getting around it because the code I removed in that commit had the
"fortunate" side effect of emitting narrower regions that didn't hit
the hardware stride limit after lowering. Beyond fixing the
regression this fixes ~90 additional Vulkan 1.1 subgroup CTS tests on
ICL (that's why this patch is marked for inclusion in mesa-stable even
though the original regressing patch was not).
According to Jason, a nearly equivalent change had been committed
previously as e8c9e65185de3e821e1 and then (mistakenly?) reverted as
a31d0382084c8aa8.
Cc: mesa-stable at lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109328
Reported-by: Mark Janes <mark.a.janes at intel.com>
Tested-by: Anuj Phogat <anuj.phogat at gmail.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit e03be78252afa8f1033b0824eff8d48df4fd6727)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3481eafb8a22bac39d98144ebea9eb254aed7586
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Wed Feb 13 16:34:27 2019 -0600
nir/xfb: Handle compact arrays in gather_xfb_info
This makes us properly handle gl_ClipDistance and gl_CullDistance.
Fixes: 19064b8c "nir: Add a pass for gathering transform feedback info"
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
(cherry picked from commit 1a93fc382b18ee6d1135952d23f0b6a8aa8cd31f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6fb3cec8bc55d140e12c5161ad5e404baa698e6f
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Wed Feb 13 16:22:37 2019 -0600
nir/xfb: Work in terms of components rather than slots
We needed to better handle cases where a chunk of a variable starts at
some non-zero location_frac and rolls over into the next slot but may
not be more than 4 dwords. For example, if gl_CullDistance is an array
of 3 things and has location_frac = 2, it will span across two vec4s but
is not, itself, bigger than a vec4. If you ignore the clip/cull special
case, it's not allowed to happen for anything else because the only
things that can span more than one slot is dvec3 and dvec4 and they're
both bigger than a vec4. The current code uses this attrib_slot thing
where we count attribute slots and iterate over them. However, that
doesn't work in the case above because gl_CullDistance will have an
attrib_slot count of 1 even though it does span two slots. We could fix
this by adjusting attrib_slot but we already have comp_mask and it's
easier to just handle it that way.
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
(cherry picked from commit 558c3145045f1c6da8bddb31ed77a418ab27f2f9)
[Emil: resolve trivial conflicts]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Conflicts:
src/compiler/nir/nir_gather_xfb_info.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8bc0c75e6418cbc003aa26e6c138bf40985d5397
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Tue Feb 12 12:49:08 2019 -0600
nir/xfb: Properly align 64-bit values
Fixes: 19064b8c "nir: Add a pass for gathering transform feedback info"
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
(cherry picked from commit 8f0fe71cc5658728adc273daa03400aab7ec6d93)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=910d7fe36cdfbee8dcd2481fd154bac165281709
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Tue Feb 12 13:03:34 2019 -0600
compiler/types: Add a contains_64bit helper
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
(cherry picked from commit 30b548fc6258e9a72722f511e377cf4716fd443c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=20e369fabf899167364637fe9c8279b15636891c
Author: Andrii Simiklit <andrii.simiklit at globallogic.com>
Date: Fri Jan 25 15:03:07 2019 +0200
i965: re-emit index buffer state on a reset option change.
Seems like we forget to update the index buffer (ib) status and
IndexedDrawCutIndexEnable or CutIndexEnable flag is left unchanged it
leads to ignoring of glEnable/glDisable functions for GL_PRIMITIVE_RESTART
in some cases. The index buffer (ib) status should be re-emmited after the
reset option change to avoid some unexpected behavior.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109451
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
Signed-off-by: Andrii Simiklit <asimiklit.work at gmail.com>
(cherry picked from commit f4f4ec941e1427142656e588244f378e469e996e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=036b326e02261d316250cbf7587299b49245e8c2
Author: Carlos Garnacho <carlosg at gnome.org>
Date: Tue Nov 20 18:06:38 2018 +0100
wayland/egl: Ensure EGL surface is resized on DRI update_buffers()
Fullscreening and unfullscreening a totem window while playing a video
sometimes results in the video subsurface not changing size along. This
is also reproducible with epiphany.
If a surface gets resized while we have an active back buffer for it, the
resized dimensions won't get neither immediately applied on the resize
callback, nor correctly synchronized on update_buffers(), as the
(now stale) surface size and currently attached buffer size still do match.
There's actually 2 things to synchronize here, first the surface query
size might not be updated yet to the wl_egl_window's (i.e. resize_callback
happened while there is a back buffer), and second the wayland buffers
would need dropping if new surface size differs with the currently attached
buffer. These are done in separate steps now.
https://bugzilla.redhat.com/show_bug.cgi?id=1650929
https://bugs.freedesktop.org/show_bug.cgi?id=109594
Fixes: a9fb331ea7d ("wayland/egl: update surface size on window resize")
Signed-off-by: Carlos Garnacho <carlosg at gnome.org>
Reviewed-by: Juan A. Suarez <jasuarez at igalia.com>
Reviewed-by: Daniel Stone <daniels at collabora.com>
Tested-by: Bastien Nocera <hadess at hadess.net>
Tested-by: Denys Kostin <denys.kostin at globallogic.com>
(cherry picked from commit 30a01cd9232ed83a0259d184b82e050bae219ed3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9b483d945b50a8ca037bbbf43b37781845a92943
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Wed Feb 20 02:19:42 2019 +0100
radv: Sync ETC2 whitelisted devices.
Fixes: 4bb6c49375e "radv: Allow ETC2 on RAVEN and VEGA10 instead of all GFX9."
Reviewed-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit 7631feaa0040616585cf69b52241d2b06b82b524)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c7aeed2925377cac41226b8f7b6672fd68334699
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Feb 19 17:29:52 2019 -0500
driconf: add Civ6Sub executable for Civilization 6
I'm getting Civ6Sub instead of Civ6.
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit bff8da6c591e55e4b5f04aea1fef29e6230e9222)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d46291c003fcd4d72e5ff0b0f41b188a314b6f3c
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Feb 19 17:21:20 2019 -0500
radeonsi: always enable NIR for Civilization 6 to fix corruption
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104602
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit ae21bdf47cacafdf69b904cbf3e433cbe0cccb84)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=444d1ccc282b10b6d62d8d72919c33a36d2c37c8
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Feb 19 17:20:01 2019 -0500
radeonsi: add driconf option radeonsi_enable_nir
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit ccbfe44e5ff88a19451701561f752c6046677122)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c1fa0ec0e5e227ef2fad51ac79a7dd849f0e0689
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Thu Dec 6 12:11:00 2018 +0000
radv: ensure export arguments are always float
So that the signature is correct and consistent, the inputs to a export
intrinsic should always be 32-bit floats.
This and the previous commit fixes a large amount crashes from
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_int_*
tests
Fixes: b722b29f10d ('radv: add support for 16bit input/output')
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit 0ca550e01ac55c67c2deef50f5cb750a0181352b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0633c4ef9d656729847bc8c9eee37b60a121a61d
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Thu Dec 6 12:10:41 2018 +0000
radv: bitcast 16-bit outputs to integers
16-bit outputs are stored as 16-bit floats in the outputs array, so they
have to be bitcast.
Fixes: b722b29f10d ('radv: add support for 16bit input/output')
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit 64065aa504c4872a15f7b0894b6037a6b2bcae65)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d0f7e6f218101b77da219d79690df4e7ee61de1b
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Feb 18 17:42:10 2019 +0100
radv: fix writing the alpha channel of MRT0 when alpha coverage is enabled
This version is better and safer.
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 47616810ed7cfce21d239391131ad9a5ef558b52)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=242ef8d20b41d7d6e01a6366b9c4e7e8ac336dca
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Fri Feb 15 18:02:52 2019 +0100
radv: write the alpha channel of MRT0 when alpha coverage is enabled
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109597
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 0d8f09629377da9cf48ab4315574d69fdef5369d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=41d78f9ed7ebbdd8bd10268635e9bc883a8ffc33
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Mon Feb 11 22:39:45 2019 -0600
intel/fs: Bail in optimize_extract_to_float if we have modifiers
This fixes a bug in runscape where we were optimizing x >> 16 to an
extract and then negating and converting to float. The NIR to fs pass
was dropping the negate on the floor breaking a geometry shader and
causing it to render nothing.
Fixes: 1f862e923cb "i965/fs: Optimize float conversions of byte/word..."
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109601
Tested-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Matt Turner <mattst88 at gmail.com>
(cherry picked from commit 367b0ede4d9115aba772d6e46ec73642761f7ff6)
[Emil: resolve trivial conflicts]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Conflicts:
src/intel/compiler/brw_fs_nir.cpp
More information about the mesa-commit
mailing list