Mesa (master): radv: fix binding transform feedback buffers

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Mar 20 08:04:52 UTC 2019


Module: Mesa
Branch: master
Commit: 4fa61273a8c8809a9ca0a1473b5e361aa5715ae0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4fa61273a8c8809a9ca0a1473b5e361aa5715ae0

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Tue Mar  5 18:09:12 2019 +0100

radv: fix binding transform feedback buffers

The mask should be accumulated if two calls are used for
binding two buffers at different indexes. Otherwise, the
driver only accounts for the last one.

Noticed while glancing at this code.

Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

---

 src/amd/vulkan/radv_cmd_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index ae8f50d0348..fdf3024147d 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -4993,7 +4993,7 @@ void radv_CmdBindTransformFeedbackBuffersEXT(
 		enabled_mask |= 1 << idx;
 	}
 
-	cmd_buffer->state.streamout.enabled_mask = enabled_mask;
+	cmd_buffer->state.streamout.enabled_mask |= enabled_mask;
 
 	cmd_buffer->state.dirty |= RADV_CMD_DIRTY_STREAMOUT_BUFFER;
 }




More information about the mesa-commit mailing list