Mesa (staging/19.0): radv: fix binding transform feedback buffers

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Mar 20 15:54:21 UTC 2019


Module: Mesa
Branch: staging/19.0
Commit: 62b2aea3ee46027c7c0e9fe0f1a295927abe5b42
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=62b2aea3ee46027c7c0e9fe0f1a295927abe5b42

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Tue Mar  5 18:09:12 2019 +0100

radv: fix binding transform feedback buffers

The mask should be accumulated if two calls are used for
binding two buffers at different indexes. Otherwise, the
driver only accounts for the last one.

Noticed while glancing at this code.

Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 4fa61273a8c8809a9ca0a1473b5e361aa5715ae0)

---

 src/amd/vulkan/radv_cmd_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index e800bbd061a..13f7c6a01cd 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -4905,7 +4905,7 @@ void radv_CmdBindTransformFeedbackBuffersEXT(
 		enabled_mask |= 1 << idx;
 	}
 
-	cmd_buffer->state.streamout.enabled_mask = enabled_mask;
+	cmd_buffer->state.streamout.enabled_mask |= enabled_mask;
 
 	cmd_buffer->state.dirty |= RADV_CMD_DIRTY_STREAMOUT_BUFFER;
 }




More information about the mesa-commit mailing list