Mesa (staging/18.3): 23 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Mar 26 19:02:17 UTC 2019
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cdd3eac6230ce2f192c57e74ed24115a9aa002dd
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Tue Mar 19 01:29:43 2019 +0100
ac/nir: Return frag_coord as integer.
To preserve the invariant that nir ssa defs are integers or pointers
in LLVM.
CC: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Reviewed-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit 82075e3c421b1de7661e61879f2dcbc66011e466)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7c271fd48262c9708cd3ab4e11c1e44a8e5349ff
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Tue Mar 19 11:01:53 2019 +0200
anv/radv: release memory allocated by glsl types during spirv_to_nir
Fixes leaks for each glsl_type generated:
==32470== 384 bytes in 3 blocks are possibly lost in loss record 18 of 18
==32470== at 0x483880B: malloc (vg_replace_malloc.c:309)
==32470== by 0x4C43F4A: ralloc_size (ralloc.c:119)
==32470== by 0x4C44014: rzalloc_size (ralloc.c:151)
==32470== by 0x4C44258: rzalloc_array_size (ralloc.c:215)
==32470== by 0x4D38957: glsl_type::glsl_type(glsl_struct_field const*, unsigned int, char const*) (glsl_types.cpp:114)
==32470== by 0x4D3BEED: glsl_type::get_struct_instance(glsl_struct_field const*, unsigned int, char const*) (glsl_types.cpp:1146)
==32470== by 0x4D42ECC: glsl_struct_type (nir_types.cpp:501)
==32470== by 0x4CDB5A1: vtn_handle_type (spirv_to_nir.c:1269)
==32470== by 0x4CE53DD: vtn_handle_variable_or_type_instruction (spirv_to_nir.c:4018)
==32470== by 0x4CD8CFF: vtn_foreach_instruction (spirv_to_nir.c:365)
==32470== by 0x4CE5E6B: spirv_to_nir (spirv_to_nir.c:4490)
==32470== by 0x497AF10: anv_shader_compile_to_nir (anv_pipeline.c:173)
v2: move release call to vkDestroyInstance
v3: apply fix also to radv driver
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 4e1bbb000cdfe4ba01bee5a6868c54fed7285dae)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d29dca6d1589336cd33e6fbfec01e765859036f1
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date: Fri Mar 1 21:35:41 2019 +1100
st/glsl_to_nir: fix incorrect arrary access
This fixes a segfault when we try to access the array using a
-1 when the array wasn't allocated in the first place.
Before 7536af670b75 we would just access a pre-allocated array
that was also load/stored to/from the shader cache. But now the
cache will no longer allocate these arrays if they are empty.
The change resulted in tests such as the following segfaulting
when run with a warm shader cache.
tests/spec/arb_arrays_of_arrays/execution/sampler/fs-struct-const-index.shader_test
(cherry picked from commit cb2898f4786f9e80e0a2dd061d620fc7ced6f1ea)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=643754ce678a16643e7d60ffe967a8000abc15d2
Author: Józef Kucia <joseph.kucia at gmail.com>
Date: Tue Mar 12 16:07:10 2019 +0100
radv: Fix driverUUID
Fixes: 14cad8786a8 ("radv: generate the same driver UUID as radeonsi")
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit c077d5d7de7628fe2fdfa67cee92efaab65a578e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=eac9b871c9291c6ba4d682bed2f291d0890b67e9
Author: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Date: Tue Sep 4 11:42:04 2018 +0300
glsl: Cross validate variable's invariance by explicit invariance only
'invariant' qualifier is propagated on variables which are used
to calculate other invariant variables, however when we are matching
variable's declarations we should take into account only explicitly
declared invariance because invariance propagation is an implementation
specific detail.
Thus new flag is added to ir_variable_data which indicates 'invariant'
qualifier being explicitly set in the shader.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100316
Fixes: 89b60492 ('glsl: Add a pass to propagate the "invariant" and
"precise" qualifiers')
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
(cherry picked from commit ea9bde151f1394ff82b73d028c2a3a747723e525)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f3617aa99cd2955864a25a38e12f0a80acfcc8bc
Author: Józef Kucia <joseph.kucia at gmail.com>
Date: Tue Mar 12 16:11:41 2019 +0100
mesa: Fix GL_NUM_DEVICE_UUIDS_EXT
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
(cherry picked from commit 1d996ef7144f97ce948fb8e8ec5792898bea56f6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e9ff2b5276b8838e0cb6b86c6e3dab757e4f83ba
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Wed Mar 20 10:50:10 2019 -0700
bin/install_megadrivers.py: Correctly handle DESTDIR=''
Currently if destdir is set to '' then the resulting libdir will have
it's first character replaced by / instead of / being prepended to the
string. This was the result of ensuring that that DESTDIR wouldn't be
ignored if libdir was absolute, since the only cases that meson allows
the libdir to be absolute is if the prefix is /, this won't be a
problem.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110211
Fixes: ae3f45c11e3f934939b90445471da8f18b057bc5
("bin/install_megadrivers: fix DESTDIR and -D*-path")
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
(cherry picked from commit 4188dd7879a374b698d5f50c84cd26b2606f1ee3)
Squashed with:
bin/install_megadrivers.py: Fix regression for set DESTDIR
The previous patch tried to address a bug when DESTDIR is '', however,
it introduces a bug when DESTDIR is not '', and fakeroot is used. This
patch does fix that, and has been tested with the arch pkg-build to
ensure it isn't regressed.
Fixes: 093a1ade4e24b7dd701a093d30a71efd669fe9c8
("bin/install_megadrivers.py: Correctly handle DESTDIR=''")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110221
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
(cherry picked from commit ed96038e55b37501dae0be09287a6209a966eb85)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=76719ecbb325ebb9e83574b530db166efc121d87
Author: Dave Airlie <airlied at redhat.com>
Date: Wed Mar 20 13:11:40 2019 +1000
softpipe: fix texture view crashes
I noticed we crashed piglit arb_texture_view-rendering-formats
when run on softpipe.
This fixes the clear tiles to use the surface format not the
underlying storage format.
This fixes a bunch of srgb piglits as well.
Fixes: 396ac41fc28 (softpipe: add integer support)
Reviewed-by: Brian Paul <brianp at vmware.com>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
(cherry picked from commit 04189565a01afbecc179fb4945a80754ee6fcfb4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=96a01a5eed07fc68b7df819f0413900d9b97b385
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Tue Mar 5 18:09:12 2019 +0100
radv: fix binding transform feedback buffers
The mask should be accumulated if two calls are used for
binding two buffers at different indexes. Otherwise, the
driver only accounts for the last one.
Noticed while glancing at this code.
Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 4fa61273a8c8809a9ca0a1473b5e361aa5715ae0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0f976b92f8eb0d946781d8ff06f7eb063f087142
Author: Andres Gomez <agomez at igalia.com>
Date: Fri Feb 8 19:06:08 2019 +0200
Revert "glsl: relax input->output validation for SSO programs"
This reverts commit 1aa5738e666a9534c7e5b46f077327e6d647c64f.
This patch incorrectly asumed that for SSOs no inner interface
matching check was needed.
From the ARB_separate_shader_objects spec v.25:
" With separable program objects, interfaces between shader stages
may involve the outputs from one program object and the inputs
from a second program object. For such interfaces, it is not
possible to detect mismatches at link time, because the programs
are linked separately. When each such program is linked, all
inputs or outputs interfacing with another program stage are
treated as active. The linker will generate an executable that
assumes the presence of a compatible program on the other side of
the interface. If a mismatch between programs occurs, no GL error
will be generated, but some or all of the inputs on the interface
will be undefined."
This completes the fix from commit:
3be05dd2679 ("glsl/linker: don't fail non static used inputs without matching outputs")
Fixes: 1aa5738e666 ("glsl: relax input->output validation for SSO programs")
Cc: Tapani Pälli <tapani.palli at intel.com>
Cc: Timothy Arceri <tarceri at itsqueeze.com>
Cc: Ilia Mirkin <imirkin at alum.mit.edu>
Cc: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
Cc: Ian Romanick <ian.d.romanick at intel.com>
Signed-off-by: Andres Gomez <agomez at igalia.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit ab28dca0334746d1d6cb3f1b18550e3cbfb41d77)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=208fd66d80b16a9c70d7228256cdd3d3f4cbe2f7
Author: Andres Gomez <agomez at igalia.com>
Date: Fri Jan 18 18:33:10 2019 +0200
glsl/linker: simplify xfb_offset vs xfb_stride overflow check
Current implementation uses a complicated calculation which relies in
an implicit conversion to check the integral part of 2 division
results.
However, the calculation actually checks that the xfb_offset is
smaller or a multiplier of the xfb_stride. For example, while this is
expected to fail, it actually succeeds:
"
...
layout(xfb_buffer = 2, xfb_stride = 12) out block3 {
layout(xfb_offset = 0) vec3 c;
layout(xfb_offset = 12) vec3 d; // ERROR, requires stride of 24
};
...
"
Fixes: 2fab85aaea5 ("glsl: add xfb_stride link time validation")
Cc: Timothy Arceri <tarceri at itsqueeze.com>
Signed-off-by: Andres Gomez <agomez at igalia.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit 422882e78f2cf0ab69ff4a58f3c9465fcb5fef0d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=479b11040f1ab02d637f6931f5cfcbca709e26e6
Author: Andres Gomez <agomez at igalia.com>
Date: Fri Dec 28 00:57:29 2018 +0200
glsl/linker: don't fail non static used inputs without matching outputs
If there is no Static Use of an input variable, the linker shouldn't
fail whenever there is no defined matching output variable in the
previous stage.
From page 47 (page 51 of the PDF) of the GLSL 4.60 v.5 spec:
" Only the input variables that are statically read need to be
written by the previous stage; it is allowed to have superfluous
declarations of input variables."
Now, we complete this exception whenever the input variable has an
explicit location. Previously, 18004c338f6 ("glsl: fail when a
shader's input var has not an equivalent out var in previous") took
care of the cases in which the input variable didn't have an explicit
location.
v2: do the location based interface matching check regardless on
whether it is a separable program or not (Ilia).
Fixes: 1aa5738e666 ("glsl: relax input->output validation for SSO programs")
Cc: Timothy Arceri <tarceri at itsqueeze.com>
Cc: Iago Toral Quiroga <itoral at igalia.com>
Cc: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
Cc: Tapani Pälli <tapani.palli at intel.com>
Cc: Ian Romanick <ian.d.romanick at intel.com>
Cc: Ilia Mirkin <imirkin at alum.mit.edu>
Signed-off-by: Andres Gomez <agomez at igalia.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit 3be05dd2679b2525ff80bac715d6ea097295c9ea)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=db517e336c82721acb01d5a2b8580b345533e2b5
Author: Andres Gomez <agomez at igalia.com>
Date: Thu Dec 20 03:09:57 2018 +0200
glsl: correctly validate component layout qualifier for dvec{3,4}
From page 62 (page 68 of the PDF) of the GLSL 4.50 v.7 spec:
" A dvec3 or dvec4 can only be declared without specifying a
component."
Therefore, using the "component" qualifier with a dvec3 or dvec4
should result in a compiling error.
v2: enhance the error message (Timothy).
Fixes: 94438578d21 ("glsl: validate and store component layout qualifier in GLSL IR")
Cc: Timothy Arceri <tarceri at itsqueeze.com>
Cc: Kenneth Graunke <kenneth at whitecape.org>
Signed-off-by: Andres Gomez <agomez at igalia.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit a96093136bddfe17661f1de54228fe4b5618ba8a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f9160aa98b529de77133780a508afd1ce91f0072
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Mon Mar 18 22:20:40 2019 +0100
radv: Use correct image view comparison for fast clears.
The if is actually returning true on success, enabling fast clears, so we
need to have the test succeed when the iview dimensions are right.
Fixes: d5400a5ec2a "radv: provide a helper for comparing an image extents."
Reviewed-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit a777c3d7cb0a89f6c63a637e6db32cc1bf33b54c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8e909034639207e5dee8abb03e1537d4680398da
Author: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>
Date: Sat Mar 16 19:56:59 2019 +0100
vulkan/util: meson build - add wayland client include
Without this the build breaks with:
In file included from ../src/vulkan/util/vk_util.h:32,
from ../src/vulkan/util/vk_util.c:28:
../include/vulkan/vulkan.h:51:10: fatal error: wayland-client.h: No such file or
directory
#include <wayland-client.h>
^~~~~~~~~~~~~~~~~~
compilation terminated.
The above misses the include directory for wayland:
-I/usr/include/wayland
Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
(cherry picked from commit 29179f58c6ba8099859ea25900214dbbd3814a92)
[Emil: resolve trivial conflicts]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Conflicts:
src/vulkan/util/meson.build
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f29b229664ed181169c777f151e902a7b405611e
Author: Mark Janes <mark.a.janes at intel.com>
Date: Thu Dec 6 16:35:42 2018 -0800
mesa: properly report the length of truncated log messages
_mesa_log_msg must provide the length of the string passed into the
KHR_debug api. When the string formatted by _mesa_gl_vdebugf exceeds
MAX_DEBUG_MESSAGE_LENGTH, the length is incorrectly set to the number
of characters that would have been written if enough space had been
available.
Fixes: 30256805784450b8bb9d4dabfb56226271ca9d24
("mesa: Add support for GL_ARB_debug_output with dynamic ID allocation.")
Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
(cherry picked from commit eb1a869a5d19bfd8a0d4099afd58f180997e4663)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2c163bfe68a970a9fc323ceade7dee7feee77ae9
Author: Plamena Manolova <plamena.manolova at intel.com>
Date: Tue Mar 12 21:25:36 2019 +0200
i965: Disable ARB_fragment_shader_interlock for platforms prior to GEN9
ARB_fragment_shader_interlock depends on memory fences to
ensure fragment ordering and this ordering guarantee is
only supported from GEN9 onwards.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109980
Fixes: 939312702e35 "i965: Add ARB_fragment_shader_interlock support."
Signed-off-by: Plamena Manolova <plamena.n.manolova at gmail.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 19ab08200179e71af42ce6e1b91f502e50f915b3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6f76ecffbccf38a9c4026ab2242e8140c6b5230f
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Tue Mar 12 22:55:14 2019 -0500
anv/pass: Flag the need for a RT flush for resolve attachments
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
Cc: mesa-stable at lists.freedesktop.org
(cherry picked from commit 489bf2de237a190b966a412efda89d12d1daacde)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ec770b43b974cc86ce4bf996aa0616ceafa4e69c
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Mon Mar 18 15:57:14 2019 +0000
docs: add sha256 checksums for 18.3.5
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=022708cb40a997e796f95d011a0e6c64a7333fe0
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Mon Mar 18 15:45:53 2019 +0000
docs: add release notes for 18.3.5
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2a1e743ed90c3fd0188c52452c9bfcbe9e94b850
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Mon Mar 18 15:37:03 2019 +0000
Update version to 18.3.5
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=60fb5f4b8677ad316feb1d949617b119392b1a2e
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Mar 14 14:27:03 2019 +0100
radv: always initialize HTILE when the src layout is UNDEFINED
HTILE should always be initialized when transitioning from
VK_IMAGE_LAYOUT_UNDEFINED to other image layouts. Otherwise,
if an app does a transition from UNDEFINED to GENERAL, the
driver doesn't initialize HTILE and it tries to decompress
the depth surface. For some reasons, this results in VM faults.
Cc: mesa-stable at lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107563
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 3a2e93147f7fa4a6fd17313353113a33291c5ce0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bdd5f24c1b1bd94b8725263cf287c5987fe7229a
Author: Kevin Strasser <kevin.strasser at intel.com>
Date: Mon Jan 28 10:42:44 2019 -0800
egl/dri: Avoid out of bounds array access
indexConfigAttrib iterates over every index in the dri driver, possibly
exceeding __DRI_ATTRIB_MAX. In other words, if the dri driver has newer
attributes libEGL will end up reading from uninitialized memory through
dri2_to_egl_attribute_map[].
Signed-off-by: Kevin Strasser <kevin.strasser at intel.com>
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit 70b36c0ef939048acb9c4727b2e4280fc090eb74)
More information about the mesa-commit
mailing list