Mesa (18.3): radv: Use correct image view comparison for fast clears.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Mar 27 13:50:47 UTC 2019


Module: Mesa
Branch: 18.3
Commit: f9160aa98b529de77133780a508afd1ce91f0072
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f9160aa98b529de77133780a508afd1ce91f0072

Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Mon Mar 18 22:20:40 2019 +0100

radv: Use correct image view comparison for fast clears.

The if is actually returning true on success, enabling fast clears, so we
need to have the test succeed when the iview dimensions are right.

Fixes: d5400a5ec2a "radv: provide a helper for comparing an image extents."
Reviewed-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit a777c3d7cb0a89f6c63a637e6db32cc1bf33b54c)

---

 src/amd/vulkan/radv_meta_clear.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c
index d7bc4104105..c05da7a24fd 100644
--- a/src/amd/vulkan/radv_meta_clear.c
+++ b/src/amd/vulkan/radv_meta_clear.c
@@ -633,7 +633,7 @@ static bool depth_view_can_fast_clear(struct radv_cmd_buffer *cmd_buffer,
 	    iview->base_mip == 0 &&
 	    iview->base_layer == 0 &&
 	    radv_layout_is_htile_compressed(iview->image, layout, queue_mask) &&
-	    !radv_image_extent_compare(iview->image, &iview->extent))
+	    radv_image_extent_compare(iview->image, &iview->extent))
 		return true;
 	return false;
 }




More information about the mesa-commit mailing list