Mesa (master): intel/compiler: Don't always require precise lowering of flrp

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: c866500525c9717e31c39074d3e3a4db3d51ec69
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c866500525c9717e31c39074d3e3a4db3d51ec69

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Sat Aug 18 17:11:12 2018 -0700

intel/compiler: Don't always require precise lowering of flrp

No changes on any other Intel platforms.

Iron Lake and GM45 had similar results. (Iron Lake shown)
total instructions in shared programs: 8164367 -> 8135551 (-0.35%)
instructions in affected programs: 3271235 -> 3242419 (-0.88%)
helped: 13636
HURT: 90
helped stats (abs) min: 1 max: 30 x̄: 2.13 x̃: 1
helped stats (rel) min: 0.04% max: 10.77% x̄: 1.16% x̃: 0.97%
HURT stats (abs)   min: 1 max: 4 x̄: 1.80 x̃: 2
HURT stats (rel)   min: 0.26% max: 11.11% x̄: 1.76% x̃: 0.78%
95% mean confidence interval for instructions value: -2.13 -2.07
95% mean confidence interval for instructions %-change: -1.16% -1.13%
Instructions are helped.

total cycles in shared programs: 188719974 -> 188586222 (-0.07%)
cycles in affected programs: 70415766 -> 70282014 (-0.19%)
helped: 12563
HURT: 515
helped stats (abs) min: 2 max: 600 x̄: 10.90 x̃: 6
helped stats (rel) min: <.01% max: 5.48% x̄: 0.48% x̃: 0.27%
HURT stats (abs)   min: 2 max: 54 x̄: 6.07 x̃: 4
HURT stats (rel)   min: 0.01% max: 4.48% x̄: 0.24% x̃: 0.08%
95% mean confidence interval for cycles value: -10.56 -9.90
95% mean confidence interval for cycles %-change: -0.47% -0.45%
Cycles are helped.

LOST:   0
GAINED: 13

Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 src/intel/compiler/brw_nir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c
index 7e6f9d2d436..e1f5b28d874 100644
--- a/src/intel/compiler/brw_nir.c
+++ b/src/intel/compiler/brw_nir.c
@@ -610,7 +610,7 @@ brw_nir_optimize(nir_shader *nir, const struct brw_compiler *compiler,
           */
          if (OPT(nir_lower_flrp,
                  lower_flrp,
-                 is_scalar /* always_precise */,
+                 false /* always_precise */,
                  compiler->devinfo->gen >= 6)) {
             OPT(nir_opt_constant_folding);
          }