Mesa (master): freedreno/ir3: remove obsolete comment

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sat Nov 9 03:07:48 UTC 2019


Module: Mesa
Branch: master
Commit: df229977c38c0dbebfe59e9270de4013381c0735
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=df229977c38c0dbebfe59e9270de4013381c0735

Author: Rob Clark <robdclark at chromium.org>
Date:   Thu Oct 24 11:24:15 2019 -0700

freedreno/ir3: remove obsolete comment

The meta PHI instruction was removed long ago.  And fanin/fanout
themselves to not contribute actual instructions (at least not by the
time you get to sched, they may prevent copy-propagating away a mov)

Signed-off-by: Rob Clark <robdclark at chromium.org>

---

 src/freedreno/ir3/ir3.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/freedreno/ir3/ir3.h b/src/freedreno/ir3/ir3.h
index f3343737573..17c4178d963 100644
--- a/src/freedreno/ir3/ir3.h
+++ b/src/freedreno/ir3/ir3.h
@@ -774,10 +774,6 @@ static inline bool is_bool(struct ir3_instruction *instr)
 
 static inline bool is_meta(struct ir3_instruction *instr)
 {
-	/* TODO how should we count PHI (and maybe fan-in/out) which
-	 * might actually contribute some instructions to the final
-	 * result?
-	 */
 	return (opc_cat(instr->opc) == -1);
 }
 




More information about the mesa-commit mailing list