Mesa (master): nir/divergence: improve DA of shuffle

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Nov 12 17:59:15 UTC 2019


Module: Mesa
Branch: master
Commit: c877f4d320b431f64634b8cda057311ea17c9a26
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c877f4d320b431f64634b8cda057311ea17c9a26

Author: Rhys Perry <pendingchaos02 at gmail.com>
Date:   Tue Nov 12 15:29:45 2019 +0000

nir/divergence: improve DA of shuffle

If the data is uniform, then it's really a uniform copy. If the index is
uniform, then it's really a read_invocation.

Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>

---

 src/compiler/nir/nir_divergence_analysis.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/compiler/nir/nir_divergence_analysis.c b/src/compiler/nir/nir_divergence_analysis.c
index 301d7a4820b..9b8f9cb6349 100644
--- a/src/compiler/nir/nir_divergence_analysis.c
+++ b/src/compiler/nir/nir_divergence_analysis.c
@@ -200,7 +200,6 @@ visit_intrinsic(bool *divergent, nir_intrinsic_instr *instr,
    case nir_intrinsic_ballot_find_lsb:
    case nir_intrinsic_ballot_find_msb:
    case nir_intrinsic_ballot_bit_count_reduce:
-   case nir_intrinsic_shuffle:
    case nir_intrinsic_shuffle_xor:
    case nir_intrinsic_shuffle_up:
    case nir_intrinsic_shuffle_down:
@@ -247,6 +246,11 @@ visit_intrinsic(bool *divergent, nir_intrinsic_instr *instr,
       break;
    }
 
+   case nir_intrinsic_shuffle:
+      is_divergent = divergent[instr->src[0].ssa->index] &&
+                     divergent[instr->src[1].ssa->index];
+      break;
+
    /* Intrinsics which are always divergent */
    case nir_intrinsic_load_color0:
    case nir_intrinsic_load_color1:




More information about the mesa-commit mailing list