Mesa (master): pan/midgard: Describe quirk MIDGARD_BROKEN_LOD

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: 68c2c7962a98673a2c589cc88ad19791a8d47cfd
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=68c2c7962a98673a2c589cc88ad19791a8d47cfd

Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Tue Nov 19 21:21:19 2019 -0500

pan/midgard: Describe quirk MIDGARD_BROKEN_LOD

Corresponds to errata #10471, applies to T6xx and T720. Fixed in T760.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>

---

 src/panfrost/midgard/midgard_quirks.h | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/panfrost/midgard/midgard_quirks.h b/src/panfrost/midgard/midgard_quirks.h
index d076605a3db..359d45dbdde 100644
--- a/src/panfrost/midgard/midgard_quirks.h
+++ b/src/panfrost/midgard/midgard_quirks.h
@@ -48,17 +48,28 @@
 
 #define MIDGARD_OLD_BLEND (1 << 2)
 
+/* Errata causing the LOD clamps and bias in the sampler descriptor to be
+ * ignored. This errata affects the command stream but uses a compiler
+ * workaround (applying the clamps/bias manually in the shader. Corresponds in
+ * BASE_HW_ISSUE_10471 in kbase, described as "TEXGRD doesn't honor Sampler
+ * Descriptor LOD clamps nor bias". (I'm assuming TEXGRD is what we call
+ * textureLod) */
+
+#define MIDGARD_BROKEN_LOD (1 << 3)
+
 static inline unsigned
 midgard_get_quirks(unsigned gpu_id)
 {
         switch (gpu_id) {
         case 0x600:
         case 0x620:
-                return MIDGARD_OLD_BLEND;
+                return MIDGARD_OLD_BLEND |
+                        MIDGARD_BROKEN_LOD;
 
         case 0x720:
                 return MIDGARD_INTERPIPE_REG_ALIASING | 
-                        MIDGARD_OLD_BLEND;
+                        MIDGARD_OLD_BLEND |
+                        MIDGARD_BROKEN_LOD;
 
         case 0x820:
         case 0x830: