Mesa (master): radv: disable subgroup shuffle operations on GFX10

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Nov 25 07:22:36 UTC 2019


Module: Mesa
Branch: master
Commit: b99295fb332bcde5c4168acb5d9d9aede10519e3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b99295fb332bcde5c4168acb5d9d9aede10519e3

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Thu Nov 21 11:27:55 2019 +0100

radv: disable subgroup shuffle operations on GFX10

They are broken like on GFX6-GFX7. It seems better to disable them
instead of enabling a broken feature.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

---

 src/amd/vulkan/radv_device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index a0f7267e199..a7997cf9c20 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -1394,7 +1394,8 @@ void radv_GetPhysicalDeviceProperties2(
 							VK_SUBGROUP_FEATURE_BALLOT_BIT |
 							VK_SUBGROUP_FEATURE_CLUSTERED_BIT |
 							VK_SUBGROUP_FEATURE_QUAD_BIT;
-			if (pdevice->rad_info.chip_class >= GFX8) {
+			if (pdevice->rad_info.chip_class == GFX8 ||
+			    pdevice->rad_info.chip_class == GFX9) {
 				properties->supportedOperations |=
 							VK_SUBGROUP_FEATURE_SHUFFLE_BIT |
 							VK_SUBGROUP_FEATURE_SHUFFLE_RELATIVE_BIT;




More information about the mesa-commit mailing list