Mesa (master): aco: Make unused workgroup id's 0

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Nov 25 13:46:46 UTC 2019


Module: Mesa
Branch: master
Commit: 01eb6ef8700fa850ea63cdf0e6a4be1af2b26e9a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=01eb6ef8700fa850ea63cdf0e6a4be1af2b26e9a

Author: Connor Abbott <cwabbott0 at gmail.com>
Date:   Mon Nov 18 15:36:20 2019 +0100

aco: Make unused workgroup id's 0

It shouldn't matter, but the 1 was leftover from when it was handled
together with workgroup_size and num_work_groups.

Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>

---

 src/amd/compiler/aco_instruction_selection.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp
index ce8a7b02c77..de46348c091 100644
--- a/src/amd/compiler/aco_instruction_selection.cpp
+++ b/src/amd/compiler/aco_instruction_selection.cpp
@@ -5530,9 +5530,9 @@ void visit_intrinsic(isel_context *ctx, nir_intrinsic_instr *instr)
       Temp dst = get_ssa_temp(ctx, &instr->dest.ssa);
       struct ac_arg *args = ctx->args->ac.workgroup_ids;
       bld.pseudo(aco_opcode::p_create_vector, Definition(dst),
-                 args[0].used ? Operand(get_arg(ctx, args[0])) : Operand(1u),
-                 args[1].used ? Operand(get_arg(ctx, args[1])) : Operand(1u),
-                 args[2].used ? Operand(get_arg(ctx, args[2])) : Operand(1u));
+                 args[0].used ? Operand(get_arg(ctx, args[0])) : Operand(0u),
+                 args[1].used ? Operand(get_arg(ctx, args[1])) : Operand(0u),
+                 args[2].used ? Operand(get_arg(ctx, args[2])) : Operand(0u));
       emit_split_vector(ctx, dst, 3);
       break;
    }




More information about the mesa-commit mailing list