Mesa (master): meson: Add -Werror=gnu-empty-initializer to MSVC compat args

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Nov 26 21:28:42 UTC 2019


Module: Mesa
Branch: master
Commit: a24d6fbae60c01a39fe5a026fb568ab7facc6fbb
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a24d6fbae60c01a39fe5a026fb568ab7facc6fbb

Author: Dylan Baker <dylan at pnwbakers.com>
Date:   Thu Nov 21 09:11:45 2019 -0800

meson: Add -Werror=gnu-empty-initializer to MSVC compat args

Only clang has this argument (at least as of clang 8 and gcc 9), which
errors when using the gcc empty initializer syntax in C:

```C
struct foo f = {};
```

GCC has a warning for this, but only when using -Wpedantic, which is a
lot of noise to lose useful warnings in.

Reviewed-by: Kristian H. Kristensen <hoegsberg at google.com>
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

---

 meson.build | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/meson.build b/meson.build
index e8bec9bb389..92e45d28640 100644
--- a/meson.build
+++ b/meson.build
@@ -996,10 +996,10 @@ else
     c_vis_args += '-fvisibility=hidden'
   endif
 
-  # Check for C and C++ arguments for MSVC2013 compatibility. These are only
-  # used in parts of the mesa code base that need to compile with old versions
-  # of MSVC, mainly common code
-  foreach a : ['-Werror=pointer-arith', '-Werror=vla']
+  # Check for C and C++ arguments for MSVC compatibility. These are only used
+  # in parts of the mesa code base that need to compile with MSVC, mainly
+  # common code
+  foreach a : ['-Werror=pointer-arith', '-Werror=vla', '-Werror=gnu-empty-initializer']
     if cc.has_argument(a)
       c_msvc_compat_args += a
     endif




More information about the mesa-commit mailing list