Mesa (master): zink: error-check right variable

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: 7a63124a06b4737199301956513b7627bcaf24ac
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7a63124a06b4737199301956513b7627bcaf24ac

Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date:   Wed Nov 27 17:44:05 2019 +0100

zink: error-check right variable

That's not the value we just allocated...

CoverityID: 1455177
Reviewed-by: Dave Airlie <airlied at redhat.com>

---

 src/gallium/drivers/zink/nir_to_spirv/spirv_builder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/zink/nir_to_spirv/spirv_builder.c b/src/gallium/drivers/zink/nir_to_spirv/spirv_builder.c
index 99b9e5833bc..32d5283c217 100644
--- a/src/gallium/drivers/zink/nir_to_spirv/spirv_builder.c
+++ b/src/gallium/drivers/zink/nir_to_spirv/spirv_builder.c
@@ -840,7 +840,7 @@ get_const_def(struct spirv_builder *b, SpvOp op, SpvId type,
    }
 
    struct spirv_const *cnst = CALLOC_STRUCT(spirv_const);
-   if (!type)
+   if (!cnst)
       return 0;
 
    cnst->op = op;