Mesa (master): intel/isl: set vertical surface alignment on null surfaces

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: 12bf1308c41273e9ac9e7a7cdc48c2c594164d60
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=12bf1308c41273e9ac9e7a7cdc48c2c594164d60

Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date:   Fri Oct  4 15:51:54 2019 +0300

intel/isl: set vertical surface alignment on null surfaces

Just following the spec. Somewhat unclear whether this applies to NULL
surfaces.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/intel/isl/isl_surface_state.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c
index 4f61c1012d9..c1e91ffe963 100644
--- a/src/intel/isl/isl_surface_state.c
+++ b/src/intel/isl/isl_surface_state.c
@@ -804,6 +804,19 @@ isl_genX(null_fill_state)(void *state, struct isl_extent3d size)
       .TiledSurface = true,
       .TileWalk = TILEWALK_YMAJOR,
 #endif
+#if GEN_GEN == 7
+      /* According to PRMs: "Volume 4 Part 1: Subsystem and Cores – Shared
+       * Functions"
+       *
+       * RENDER_SURFACE_STATE::Surface Vertical Alignment
+       *
+       *    "This field must be set to VALIGN_4 for all tiled Y Render Target
+       *     surfaces."
+       *
+       * Affect IVB, HSW.
+       */
+      .SurfaceVerticalAlignment = VALIGN_4,
+#endif
       .Width = size.width - 1,
       .Height = size.height - 1,
       .Depth = size.depth - 1,