Mesa (staging/19.2): rbug: Fix use of alloca() without #include "c99_alloca.h"
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Oct 25 17:02:20 UTC 2019
Module: Mesa
Branch: staging/19.2
Commit: 87db4b93762003b5220c346ba76797b004c826f8
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=87db4b93762003b5220c346ba76797b004c826f8
Author: Jon Turney <jon.turney at dronecode.org.uk>
Date: Sat Oct 19 14:43:49 2019 +0100
rbug: Fix use of alloca() without #include "c99_alloca.h"
[12/60] Compiling C object 'src/gallium/auxiliary/eb820e8@@gallium at sta/rbug_rbug_texture.c.o'.
FAILED: src/gallium/auxiliary/eb820e8@@gallium at sta/rbug_rbug_texture.c.o
[...]
../src/gallium/auxiliary/rbug/rbug_texture.c: In function 'rbug_send_texture_info_reply':
../src/gallium/auxiliary/rbug/rbug_texture.c:302:21: error: implicit declaration of function 'alloca'; did you mean 'malloc'? [-Werror=implicit-function-declaration]
uint32_t *height = alloca(sizeof(uint32_t) * height_len);
^~~~~~
malloc
../src/gallium/auxiliary/rbug/rbug_texture.c:302:21: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
../src/gallium/auxiliary/rbug/rbug_texture.c:303:20: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
uint32_t *depth = alloca(sizeof(uint32_t) * height_len);
^~~~~~
cc1: some warnings being treated as errors
Include c99_alloca.h to portably make the alloca() prototype available.
See also: 498d9d0f, adfb9c5c, fc8139b1
Fixes: 6174cba7 ("rbug: fix transmitted texture sizes")
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
(cherry picked from commit 2649609ac540108eb567ddf36bd1ac5ec75691af)
---
src/gallium/auxiliary/rbug/rbug_texture.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/auxiliary/rbug/rbug_texture.c b/src/gallium/auxiliary/rbug/rbug_texture.c
index 768e9505cca..b0d8c60d46d 100644
--- a/src/gallium/auxiliary/rbug/rbug_texture.c
+++ b/src/gallium/auxiliary/rbug/rbug_texture.c
@@ -34,6 +34,8 @@
* Functions ending with _reply are replies to requests.
*/
+#include "c99_alloca.h"
+
#include "rbug_internal.h"
#include "rbug_texture.h"
More information about the mesa-commit
mailing list