Mesa (staging/19.2): iris: Disallow incomplete resource creation

[GitLab Mirror]

Module: Mesa
Branch: staging/19.2
Commit: 7affc43e81a7f45fe5237fef49c57a91d4646018
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7affc43e81a7f45fe5237fef49c57a91d4646018

Author: Nanley Chery <nanley.g.chery at intel.com>
Date:   Fri Aug  2 15:38:36 2019 -0700

iris: Disallow incomplete resource creation

If a modifier specifies an aux, it must be created.

Fixes: 75a3947af46 ("iris/resource: Fall back to no aux if creation fails")
Reviewed-by: Sagar Ghuge <sagar.ghuge at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit d298740a1c1c7798d21a0978d6fa5f72ee97b9fe)

---

 src/gallium/drivers/iris/iris_resource.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/iris/iris_resource.c b/src/gallium/drivers/iris/iris_resource.c
index 71f92baab49..7b708a1d3c9 100644
--- a/src/gallium/drivers/iris/iris_resource.c
+++ b/src/gallium/drivers/iris/iris_resource.c
@@ -863,8 +863,12 @@ iris_resource_create_with_modifiers(struct pipe_screen *pscreen,
       }
    }
 
-   if (!aux_enabled)
-      iris_resource_disable_aux(res);
+   if (!aux_enabled) {
+      if (res->mod_info && res->mod_info->aux_usage != ISL_AUX_USAGE_NONE)
+         goto fail;
+      else
+         iris_resource_disable_aux(res);
+   }
 
    return &res->base;