Mesa (master): panfrost: Mark (1 << 31) as unsigned

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: 6bd18bb264d02c00505c332d595625daa0a397cb
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6bd18bb264d02c00505c332d595625daa0a397cb

Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Fri Aug 30 17:34:13 2019 -0700

panfrost: Mark (1 << 31) as unsigned

I was not aware this incurred undefined behaviour; thank you cppcheck.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>

---

 src/gallium/drivers/panfrost/pan_instancing.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/gallium/drivers/panfrost/pan_instancing.c b/src/gallium/drivers/panfrost/pan_instancing.c
index e5a1e7cfae3..fc63cdbb25d 100644
--- a/src/gallium/drivers/panfrost/pan_instancing.c
+++ b/src/gallium/drivers/panfrost/pan_instancing.c
@@ -221,7 +221,7 @@ panfrost_vertex_instanced(
                 unsigned m = m_f;
 
                 /* Default case */
-                unsigned magic_divisor = m, extra_flags = 0;
+                uint32_t magic_divisor = m, extra_flags = 0;
 
                 /* e = 2^(shift + 32) % d */
                 uint64_t e = t % hw_divisor;
@@ -234,8 +234,8 @@ panfrost_vertex_instanced(
                 }
 
                 /* Top flag implicitly set */
-                assert(magic_divisor & (1 << 31));
-                magic_divisor &= ~(1 << 31);
+                assert(magic_divisor & (1u << 31));
+                magic_divisor &= ~(1u << 31);
 
                 /* Upload to two different slots */