Mesa (staging/19.2): freedreno/drm-shim: fix mem leak

[GitLab Mirror]

Module: Mesa
Branch: staging/19.2
Commit: 0bbf6eab521e42d92682b8cac21d0f9514562346
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0bbf6eab521e42d92682b8cac21d0f9514562346

Author: Eric Engestrom <eric.engestrom at intel.com>
Date:   Mon Aug 26 15:42:32 2019 +0100

freedreno/drm-shim: fix mem leak

Fixes: 494ecef6b42198ab6c3e ("freedreno: Add support for drm-shim.")
Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
(cherry picked from commit c4969b0a25982505dd784257d7c12f1abe8b2180)

---

 src/freedreno/drm-shim/freedreno_noop.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/freedreno/drm-shim/freedreno_noop.c b/src/freedreno/drm-shim/freedreno_noop.c
index 66bb53dc5d3..6a3fbb7b67f 100644
--- a/src/freedreno/drm-shim/freedreno_noop.c
+++ b/src/freedreno/drm-shim/freedreno_noop.c
@@ -84,14 +84,15 @@ msm_ioctl_gem_info(int fd, unsigned long request, void *arg)
 	switch (args->info) {
 	case MSM_INFO_GET_OFFSET:
 		args->value = drm_shim_bo_get_mmap_offset(shim_fd, bo);
-		return 0;
+		break;
 	case MSM_INFO_GET_IOVA:
 		args->value = msm_bo(bo)->offset;
-		return 0;
+		break;
 	case MSM_INFO_SET_NAME:
-		return 0;
+		break;
 	default:
 		fprintf(stderr, "Unknown DRM_IOCTL_MSM_GEM_INFO %d\n", args->info);
+		drm_shim_bo_put(bo);
 		return -1;
 	}