Mesa (master): lima/gpir: Only try to place actual children

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Sep 24 07:15:07 UTC 2019


Module: Mesa
Branch: master
Commit: 2df2e081fde5ff84ce87fe4763e8e6a3372694e8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2df2e081fde5ff84ce87fe4763e8e6a3372694e8

Author: Connor Abbott <cwabbott0 at gmail.com>
Date:   Tue Sep 10 21:11:42 2019 +0700

lima/gpir: Only try to place actual children

When picking a node to be scheduled, we try to schedule its children as
well. But we shouldn't try to schedule nodes which only have a fake
dependency on the original node, since this isn't the point of
scheduling children at the same time and can break some expectations of
the rest of the code.

Reviewed-by: Vasily Khoruzhick <anarsoul at gmail.com>

---

 src/gallium/drivers/lima/ir/gp/scheduler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/lima/ir/gp/scheduler.c b/src/gallium/drivers/lima/ir/gp/scheduler.c
index 076794a4860..3b490974fc0 100644
--- a/src/gallium/drivers/lima/ir/gp/scheduler.c
+++ b/src/gallium/drivers/lima/ir/gp/scheduler.c
@@ -706,7 +706,7 @@ static int _schedule_try_node(sched_ctx *ctx, gpir_node *node, bool speculative)
    int score = 0;
 
    gpir_node_foreach_pred(node, dep) {
-      if (!gpir_is_input_node(dep->pred))
+      if (dep->type != GPIR_DEP_INPUT)
          continue;
 
       int pred_score = INT_MIN;




More information about the mesa-commit mailing list