Mesa (master): turnip: Advertise 8 bit subpixel precision
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Apr 3 16:47:15 UTC 2020
Module: Mesa
Branch: master
Commit: 355abfeed5fd234433a24ce983e3abc48c2d2b58
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=355abfeed5fd234433a24ce983e3abc48c2d2b58
Author: Brian Ho <brian at brkho.com>
Date: Thu Mar 12 14:27:29 2020 -0700
turnip: Advertise 8 bit subpixel precision
Previously, turnip advertised 4-bit subpixel precision when in
practice, a6xx seems to render with 8-bit precision. This caused
dEQP-VK.renderpass2.suballocation.subpass_dependencies.late_fragment_tests.*
to fail because they compare images rendered with turnip against
ones rendered via a software reference implementation parameterized
by turnip's VkPhysicalDeviceLimits.subPixelPrecisionBits value.
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4172>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4172>
---
src/freedreno/vulkan/tu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/freedreno/vulkan/tu_device.c b/src/freedreno/vulkan/tu_device.c
index 0f72ddf0bed..f8c856e6594 100644
--- a/src/freedreno/vulkan/tu_device.c
+++ b/src/freedreno/vulkan/tu_device.c
@@ -803,7 +803,7 @@ tu_GetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice,
.maxComputeWorkGroupCount = { 65535, 65535, 65535 },
.maxComputeWorkGroupInvocations = 2048,
.maxComputeWorkGroupSize = { 2048, 2048, 2048 },
- .subPixelPrecisionBits = 4 /* FIXME */,
+ .subPixelPrecisionBits = 8,
.subTexelPrecisionBits = 4 /* FIXME */,
.mipmapPrecisionBits = 4 /* FIXME */,
.maxDrawIndexedIndexValue = UINT32_MAX,
More information about the mesa-commit
mailing list