Mesa (staging/20.0): 25 new commits

Thu Apr 9 21:28:52 UTC 2020

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=019bb88019bf5f9cdb7b1574fdf0c82fdeeec1ac
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Wed Apr 8 13:53:47 2020 +0200

    radv: Use correct buffer count with variable descriptor set sizes.

    Fixes dEQP-VK.binding_model.descriptorset_random.sets16.noarray.ubolimitlow.sbolimitlow.imglimitlow.iublimitlow.frag.ialimitlow.0

    CC: <mesa-stable at lists.freedesktop.org>
    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2607
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4489>
    (cherry picked from commit a7e2efa7c95b78373d8a4b7b88ceb7b3769e6eaa)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=abdb320af446226e23ccb1f0b6a271d19596e2a9
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Tue Apr 7 22:23:09 2020 +0200

    radv: Consider maximum sample distances for entire grid.

    The other pixels in the grid might have samples with a larger
    distance than the (0,0) pixel.

    Fixes dEQP-VK.pipeline.multisample.sample_locations_ext.verify_location.samples_8_packed
    when CTS is compiled with clang.

    CC: <mesa-stable at lists.freedesktop.org>
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4480>
    (cherry picked from commit a3682670c821d34a6c6ffdcb0c68d4ed42916f98)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=26dfb62c25185c1f397aef6bbc71b1105642139e
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Tue Apr 7 11:28:32 2020 +1000

    radeonsi: don't lower constant arrays to uniforms in GLSL IR

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d15f45ca312b97e1541dd25c4292ca35ca55b3d8
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Thu Mar 26 15:19:37 2020 +0100

    radv: Store 64-bit availability bools if requested.

    Fixes dEQP-VK.query_pool.*.reset_before_copy.* on RAVEN.

    CC: <mesa-stable at lists.freedesktop.org>
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2296
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4334>
    (cherry picked from commit 940ed5078da594623639580eebefaf75d6ddad4b)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d4ef9d6ac0444dcd8a20afb5ba5b7aa028f02a31
Author: Hyunjun Ko <zzoon at igalia.com>
Date:   Mon Apr 6 04:55:19 2020 +0000

    nir: fix wrong assignment to buffer in xfb_varyings_info

    Tested with dEQP-VK.transform_feedback.fuzz.various_buffers.buffers100_instance_array_vertex

    Signed-off-by: Hyunjun Ko <zzoon at igalia.com>
    Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
    Cc: mesa-stable at lists.freedesktop.org
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4459>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4459>
    (cherry picked from commit 9f174eb2df128dd89f61ac07b5d394c24668a43c)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=de3d7dbed521c40344c9f8b2b505b6e2b13a7636
Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Wed Apr 1 12:08:41 2020 +0300

    mesa/st: release variants for active programs before unref

    Programs can be shared among many contexts and each program holds a
    variant list which has context specific variants. When context gets
    destroyed it must make sure it relases all variants, otherwise remaining
    context that utilizes same program will attempt to save a zombie shader
    for already deleted context when releasing program and its variants.

    Fixes:
       dEQP-EGL.functional.sharing.gles2.program.render

    and other flaky multihread dEQP-EGL failures.

    v2: pass program pointer via & (Marek)

    Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
    Cc: mesa-stable at lists.freedesktop.org
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4386>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4386>
    (cherry picked from commit 84e845c9696ab673f1d95fda47843028ed0c71a7)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1fdf425560130c43bad9ee1fcc6a6e40d6dbc1e6
Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Thu Apr 2 12:54:17 2020 +0300

    mesa/st: unbind shader state before deleting it

    Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
    Cc: mesa-stable at lists.freedesktop.org
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4386>
    (cherry picked from commit 4822cc97007b0dae4d095c507efc182628510434)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3d5d4ee8e661db16e3a0f12205a5a904a8f200f1
Author: Rob Clark <robdclark at chromium.org>
Date:   Wed Mar 11 13:55:17 2020 -0700

    nir: fix definition of imadsh_mix16 for vectors

    Fixes: c27b3758fa0 ("nir/opcodes: Add new 'umul_low' and 'imadsh_mix16' opcodes")
    Signed-off-by: Rob Clark <robdclark at chromium.org>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4423>
    (cherry picked from commit bf64648864224abe28d883f0c878214530ccf08c)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e70e9d4e78d9c0404d340350744fcd9bf9c65581
Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Tue Mar 31 03:19:39 2020 -0500

    nir/load_store_vectorize: Fix shared atomic info

    These were clearly copied and pasted from SSBOs.  The shared atomics
    don't have an SSBO index so their offset is src0 and data is src1.

    Fixes: ce9205c03bd20 "nir: add a load/store vectorization pass"
    Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4367>
    (cherry picked from commit 04d08ea149c05e4d5dad819269d74713aac270da)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8afe06115f5f1a83ea7d552371f333e21e1a3ef0
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date:   Thu Apr 2 21:53:02 2020 -0400

    nv50: don't try to upload MSAA settings for BUFFER textures

    We need the MSAA scaling parameters to properly fetch samples from MSAA
    textures. These are stored in the miptree which wraps all regular
    textures. However it does not wrap buffer textures, so make sure to skip
    them rather than accessing out-of-bounds or unmapped memory.

    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2727
    Fixes: 3bd40073b98 ("nv50: add support for texelFetch'ing MS textures")
    Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
    Cc: mesa-stable at lists.freedesktop.org
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4424>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4424>
    (cherry picked from commit 1288ac7632b31a20497a0e75f374f66ce3d5bc3c)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=143c99ef4bf3382cc07e59024b2abb1e8ffb7a2b
Author: Daniel Stone <daniels at collabora.com>
Date:   Wed Apr 1 12:43:51 2020 +0100

    EGL: Add eglSetDamageRegionKHR to GLVND dispatch list

    This was missed in the original conversion, which added support for
    eglSetDamageRegionKHR to local EGL exports, but forgot to generate
    updated dispatch for GLVND.

    Signed-off-by: Daniel Stone <daniels at collabora.com>
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Eric Engestrom <eric at engestrom.ch>
    Fixes: 9827547313c7 ("egl/android: support for EGL_KHR_partial_update")
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4403>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4403>
    (cherry picked from commit bfb9c08e5c5474688611c339135b8feeedc9bdd3)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7f8b89e030c5aaed4872528aead6698c7559c997
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Jan 29 14:40:17 2020 +0100

    radv/llvm: enable 16-bit storage features on GFX6-GFX7

    Should allow to play Doom Eternal on GFX6-GFX7 because the
    driver now supports storageBuffer16BitAccess.

    It's now supported and all CTS tests pass.

    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/857
    Cc: 20.0 <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4339>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4339>
    (cherry picked from commit 655e8449d0194e8482ec25e914ce7dd7fccb4f97)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=053e5a2c1356dc31a8c4ae9e8c9c51309e2aed8d
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Thu Mar 26 14:14:45 2020 +0100

    ac/nir: split 16-bit SSBO stores on GFX6

    Due to possible alignment issues, make sure to split stores of
    16-bit vectors.

    Doom Eternal requires storageBuffer16BitAccess.

    Cc: 20.0 <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4339>
    (cherry picked from commit 3cd5450df52c6a314979f5dadf2f6f9d83deb533)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fbef99b5a6b247393f81c287cd125dd7e63b87a6
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Thu Mar 26 14:14:27 2020 +0100

    ac/nir: split 16-bit load/store to global memory on GFX6

    Due to possible alignment issues, make sure to split loads/stores
    of 16-bit vectors.

    Doom Eternal requires storageBuffer16BitAccess.

    Cc: 20.0 <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4339>
    (cherry picked from commit 55fdcc03de8dd7cf62d5b6e3d2369c55e222a822)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=820c636a06d9c5a5a017a1a4525a2121ff7616f3
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Jan 29 10:45:40 2020 +0100

    radv/llvm: enable 8-bit storage features on GFX6-GFX7

    It's now supported and all CTS tests pass.

    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4339>
    (cherry picked from commit 7308f2e9121d90de55da57c9e7ec06ff2b2212bc)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a0e857c7682e134034a7f416120c4deeed6754d7
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Jan 29 14:38:55 2020 +0100

    ac/nir: split 8-bit SSBO stores on GFX6

    Due to possible alignment issues, make sure to split stores of
    8-bit vectors.

    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4339>
    (cherry picked from commit c6bf1597d1e8abf122371118b04a85ee0aa6b3d5)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=87f1e7b1d8c413d49c6a8281d63f9466fd1308f6
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Jan 29 14:37:49 2020 +0100

    ac/nir: split 8-bit load/store to global memory on GFX6

    Due to possible alignment issues, make sure to split loads/stores
    of 8-bit vectors.

    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4339>
    (cherry picked from commit 433f3380eb2ba97363ec8f47bc7d29904a4d355e)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1cf4f626d0678e707fe079a6fd832130c3b6cae5
Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Wed Apr 1 17:24:10 2020 -0500

    anv/image: Use align_u64 for image offsets

    The ALIGN functions in util/u_math.h work on uintptr_t whose size
    changes depending on your platform.  Use ones which take an explicit
    64-bit type instead to avoid 32-bit platform issues.

    Cc: mesa-stable at lists.freedesktop.org
    Reported-by: Mark Janes <mark.a.janes at intel.com>
    Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4414>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4414>
    (cherry picked from commit 5cc27d59a11ed11081b3f5c9acc3280ec412ebed)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=49a4ba5e058007a20ddf3b7fc29367d281c31262
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Tue Mar 31 10:59:20 2020 +0000

    anv/pipeline: allow more than 16 FS inputs

    A fragment shader can have more than 16 inputs, so SBE emission should
    deal with all of them.

    This fixes dEQP-VK.pipeline.max_varyings.*

    Cc: mesa-stable at lists.freedesktop.org
    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    Reviewed-by: Ivan Briano <ivan.briano at intel.com>
    Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/2010>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/2010>
    (cherry picked from commit 191ced539a18e4738e7e6bce7612779dced1625a)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=04067fbe590d15f35ef4bca9ffa4615ba0ddb9ed
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Tue Mar 31 10:45:26 2020 +0000

    intel/compiler: store the FS inputs in WM prog data

    Store the fragment shader inputs in the program data so we can use them
    later when required without needing the NIR shader.

    Cc: mesa-stable at lists.freedesktop.org
    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    Reviewed-by: Ivan Briano <ivan.briano at intel.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/2010>
    (cherry picked from commit 460de2159e2aa8e67f216d9ad8e9ce00cc8c9679)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3744a31d6c1e7ce413996ceefcaeffa78e310e45
Author: Mathias Fröhlich <mathias.froehlich at web.de>
Date:   Tue Dec 11 18:45:43 2018 +0100

    i965: Move down genX_upload_sbe in profiles.

    Avoid looping over all VARYING_SLOT_MAX urb_setup array
    entries from genX_upload_sbe. Prepare an array indirection
    to the active entries of urb_setup already in the compile
    step. On upload only walk the active arrays.

    v2: Use uint8_t to store the attribute numbers.
    v3: Change loop to build up the array indirection.
    v4: Rebase.
    v5: Style fix.

    Reviewed-by: Matt Turner <mattst88 at gmail.com>
    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
    Signed-off-by: Mathias Fröhlich <Mathias.Froehlich at web.de>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/308>
    (cherry picked from commit 630154e77b778ccb594be9e572988b05b0fc28e1)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a93c67d6332450c379435fc8029e24c09a2f511f
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Thu Mar 5 13:05:36 2020 +0000

    Revert "egl/dri2: Don't dlclose() the driver on dri2_load_driver_common failure"

    This reverts commit 1b87f4058de84d7a0bb4ead0c4f4b024d4cce8fb.

    dlclose() of the handle is perfectly reasonable, a follow-up NULL
    assignment is missing.

    As-is this causes a leak for nearly every platform, since they call
    dri2_load_driver* initially, followed by a second swrast fallback call.

    Some platforms even loop through the existing drivers probing.

    Revert the commit and add the NULL check.

    Fixes: 1b87f4058de ("egl/dri2: Don't dlclose() the driver on dri2_load_driver_common failure")
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Reviewed-by: Eric Engestrom <eric at engestrom.ch>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4084>
    (cherry picked from commit d3c91439713ecf025c7fe97aae3a4829b3f1250b)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e594e7fa272f039a8bb7d1919d2b3d17391cfe8c
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Mar 4 18:33:09 2020 +0000

    egl/drm: reinstate (kms_)swrast support

    With earlier commit we've added a generic LIBGL_ALWAYS_SOFTWARE handling
    yet did not consider that the existing codebase unconditionally errors
    out when set. That was fixed with a latter commit, while the fix itself
    added erroneous restriction for egl/drm.

    As mentioned in the report - the feature was working for ages. It was a
    Gnome developer who added kms_swrast support for gbm in the first place.

    Admittedly kms_swrast is somewhat in the middle between traditional
    swrast and HW drivers, regardless - reinstate support.

    Fixes: 47273d7312c ("egl: set UseFallback if LIBGL_ALWAYS_SOFTWARE is set")
    Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/165
    Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Acked-by: Eric Engestrom <eric at engestrom.ch>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4084>
    (cherry picked from commit fa5e800e05ab227786862383d3243e06c06d36d7)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c9f4058183b6f99c74d0cce3f942b2cf2a17aecb
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Mar 4 17:52:04 2020 +0000

    glx: set the loader_logger early and for everyone

    Currently we set the logger only for DRI3. Even though it's used nearly
    everywhere. For platforms where we don't the function is effectively a
    no-op.

    With this in place, LIBGL_DEBUG=verbose works across the board.

    Fixes: d971a4230d5 ("loader: Factor out the common driver opening logic from each loader.")
    Cc: Eric Anholt <eric at anholt.net>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Reviewed-by: Eric Engestrom <eric at engestrom.ch>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4084>
    (cherry picked from commit b699d070a6de273fb3a964e05944b203d0b57090)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=800e02453ac4770f225e49eb6ef1fa9c7e73443e
Author: Dylan Baker <dylan at pnwbakers.com>
Date:   Thu Apr 9 13:30:47 2020 -0700

    .pick_status.json: Update to 089e1fb287eb9b70c191091128ed5ba7edd2960a