Mesa (master): aco: use v_subrev_f32 for fsub with an sgpr operand in src1

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sun Apr 19 18:48:49 UTC 2020


Module: Mesa
Branch: master
Commit: 425558bfd595ed3a7a049ad0f47a46b8b3c4691e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=425558bfd595ed3a7a049ad0f47a46b8b3c4691e

Author: Daniel Schürmann <daniel at schuermann.dev>
Date:   Sun Apr 19 16:17:04 2020 +0100

aco: use v_subrev_f32 for fsub with an sgpr operand in src1

This fixes an accidentally introduced regression.

Fixes: 9be4be515f2a08b9c9e5ae1fc4c5dc9a830c2337 ('aco: implement 16-bit nir_op_fsub/nir_op_fadd')
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4633>

---

 src/amd/compiler/aco_instruction_selection.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp
index b4db7a0d66d..af1a5e4f111 100644
--- a/src/amd/compiler/aco_instruction_selection.cpp
+++ b/src/amd/compiler/aco_instruction_selection.cpp
@@ -1639,7 +1639,7 @@ void visit_alu_instr(isel_context *ctx, nir_alu_instr *instr)
    }
    case nir_op_fsub: {
       Temp src0 = get_alu_src(ctx, instr->src[0]);
-      Temp src1 = as_vgpr(ctx, get_alu_src(ctx, instr->src[1]));
+      Temp src1 = get_alu_src(ctx, instr->src[1]);
       if (dst.regClass() == v2b) {
          Temp tmp = bld.tmp(v1);
          if (src1.type() == RegType::vgpr || src0.type() != RegType::vgpr)



More information about the mesa-commit mailing list