Mesa (master): tu: Fix the advertised maxFragmentInputComponents

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Apr 21 10:20:43 UTC 2020


Module: Mesa
Branch: master
Commit: ae169f38cead48a669d39fcd4ab7747da56e19c2
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ae169f38cead48a669d39fcd4ab7747da56e19c2

Author: Connor Abbott <cwabbott0 at gmail.com>
Date:   Mon Apr 20 13:41:42 2020 +0200

tu: Fix the advertised maxFragmentInputComponents

This appears to be limited by VPC_CNTL_0::NUMNONPOSVAR, which is an
8-bit bitfield with no possibility for expansion. Also, in practice
we'll be limited by the vertex shader output maximum, which includes
gl_Position, of 128, so that users won't be able to use more than 124
components anyways. Lower it to match the GL blob.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4641>

---

 src/freedreno/vulkan/tu_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/freedreno/vulkan/tu_device.c b/src/freedreno/vulkan/tu_device.c
index e1b495b4440..006f7d4e73b 100644
--- a/src/freedreno/vulkan/tu_device.c
+++ b/src/freedreno/vulkan/tu_device.c
@@ -788,7 +788,7 @@ tu_GetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice,
       .maxGeometryOutputComponents = 128,
       .maxGeometryOutputVertices = 256,
       .maxGeometryTotalOutputComponents = 1024,
-      .maxFragmentInputComponents = 128,
+      .maxFragmentInputComponents = 124,
       .maxFragmentOutputAttachments = 8,
       .maxFragmentDualSrcAttachments = 1,
       .maxFragmentCombinedOutputResources = 8,



More information about the mesa-commit mailing list