Mesa (master): mesa/gallium: do not use enum for bit-allocated member

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Apr 21 22:15:13 UTC 2020


Module: Mesa
Branch: master
Commit: 013d9e40feed336d983b728357e4ce77b871c36d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=013d9e40feed336d983b728357e4ce77b871c36d

Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date:   Fri Mar 13 13:56:44 2020 +0100

mesa/gallium: do not use enum for bit-allocated member

The signedness of enums are undefined, so on platforms with signed
enums, this isn't going to work. One such platform is Microsoft Windows.

So let's just use an unsigned here instead.

Fixes: b1c4c4c7f53 ("mesa/gallium: automatically lower alpha-testing")
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4648>

---

 src/mesa/state_tracker/st_program.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/state_tracker/st_program.h b/src/mesa/state_tracker/st_program.h
index 286fabc0117..7483450eae5 100644
--- a/src/mesa/state_tracker/st_program.h
+++ b/src/mesa/state_tracker/st_program.h
@@ -137,7 +137,7 @@ struct st_fp_variant_key
    GLuint lower_two_sided_color:1;
 
    GLuint lower_flatshade:1;
-   enum compare_func lower_alpha_func:3;
+   unsigned lower_alpha_func:3;
 
    /** needed for ATI_fragment_shader */
    char texture_targets[MAX_NUM_FRAGMENT_REGISTERS_ATI];



More information about the mesa-commit mailing list