Mesa (master): pan/bi: Document when dual-tex is triggered
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Apr 22 01:16:16 UTC 2020
Module: Mesa
Branch: master
Commit: a2c735350ff0833a9a1f045a6ec8b163b01c56df
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a2c735350ff0833a9a1f045a6ec8b163b01c56df
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Tue Apr 21 12:19:09 2020 -0400
pan/bi: Document when dual-tex is triggered
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4671>
---
src/panfrost/bifrost/disassemble.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/panfrost/bifrost/disassemble.c b/src/panfrost/bifrost/disassemble.c
index 5c655a2db22..bdf4ced3ae6 100644
--- a/src/panfrost/bifrost/disassemble.c
+++ b/src/panfrost/bifrost/disassemble.c
@@ -1415,7 +1415,11 @@ static void dump_add(FILE *fp, uint64_t word, struct bifrost_regs regs,
struct bifrost_tex_ctrl ctrl;
memcpy((char *) &ctrl, (char *) &controlBits, sizeof(ctrl));
- // TODO: figure out what actually triggers dual-tex
+ /* Dual-tex triggered for adjacent texturing
+ * instructions with the same coordinates to different
+ * textures/samplers. Observed for the compact
+ * (2D/normal) case. */
+
if (ctrl.result_type == 9) {
struct bifrost_dual_tex_ctrl dualCtrl;
memcpy((char *) &dualCtrl, (char *) &controlBits, sizeof(ctrl));
More information about the mesa-commit
mailing list