Mesa (master): turnip : Fix wrong offset calculation for xfb buffer.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Apr 23 01:31:35 UTC 2020


Module: Mesa
Branch: master
Commit: e892733b80fb2ecf4f48787116e47b8230fcf951
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e892733b80fb2ecf4f48787116e47b8230fcf951

Author: Hyunjun Ko <zzoon at igalia.com>
Date:   Mon Apr  6 05:14:01 2020 +0000

turnip : Fix wrong offset calculation for xfb buffer.

In vulkan, offsets are already provided through the api
vkCmdBindTransformFeedbackBuffersEXT, so this is duplicated
calculation.

Fixes : 9ff1959ca5d24afe48bec20edf7e3d059d254134

Signed-off-by: Hyunjun Ko <zzoon at igalia.com>
Reviewed-by: Brian Ho <brian at brkho.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4604>

---

 src/freedreno/vulkan/tu_cmd_buffer.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/freedreno/vulkan/tu_cmd_buffer.c b/src/freedreno/vulkan/tu_cmd_buffer.c
index f830f07e2ef..b4539745a8e 100644
--- a/src/freedreno/vulkan/tu_cmd_buffer.c
+++ b/src/freedreno/vulkan/tu_cmd_buffer.c
@@ -2817,8 +2817,6 @@ tu6_emit_streamout(struct tu_cmd_buffer *cmd, struct tu_cs *cs)
       tu_cs_emit_regs(cs, A6XX_VPC_SO_BUFFER_SIZE(i, buf->size));
 
       if (cmd->state.streamout_reset & (1 << i)) {
-         offset *= tf->stride[i];
-
          tu_cs_emit_regs(cs, A6XX_VPC_SO_BUFFER_OFFSET(i, offset));
          cmd->state.streamout_reset &= ~(1  << i);
       } else {



More information about the mesa-commit mailing list