Mesa (master): anv: Expose CS workgroup sizes based on a maximum of 64 threads

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Apr 28 15:05:49 UTC 2020


Module: Mesa
Branch: master
Commit: 81ac741f8929b90a16a0b4251f3e6da02dde6133
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=81ac741f8929b90a16a0b4251f3e6da02dde6133

Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Fri Apr 24 19:07:44 2020 -0500

anv: Expose CS workgroup sizes based on a maximum of 64 threads

Otherwise, we'll hit asserts in brw_compile_cs.

Fixes: cf12faef614ab "intel/compiler: Restrict cs_threads to 64"
Closes: #2835
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4746>

---

 src/intel/vulkan/anv_device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index 7d5b3a2a839..c5c56fbc20f 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -1412,7 +1412,8 @@ void anv_GetPhysicalDeviceProperties(
       pdevice->has_bindless_images && pdevice->has_a64_buffer_access
       ? UINT32_MAX : MAX_BINDING_TABLE_SIZE - MAX_RTS - 1;
 
-   const uint32_t max_workgroup_size = 32 * devinfo->max_cs_threads;
+   /* Limit max_threads to 64 for the GPGPU_WALKER command */
+   const uint32_t max_workgroup_size = 32 * MIN2(64, devinfo->max_cs_threads);
 
    VkSampleCountFlags sample_counts =
       isl_device_get_sample_counts(&pdevice->isl_dev);



More information about the mesa-commit mailing list