Mesa (master): pan/decode: Check for correct unknown field
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Apr 30 14:43:00 UTC 2020
Module: Mesa
Branch: master
Commit: 03963febeffadefc4f47adaf0bbd3618d5692b25
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=03963febeffadefc4f47adaf0bbd3618d5692b25
Author: Tomeu Vizoso <tomeu.vizoso at collabora.com>
Date: Mon Apr 27 16:09:57 2020 +0200
pan/decode: Check for correct unknown field
As reported by Coverity:
>>> CID 1462606: Incorrect expression (COPY_PASTE_ERROR)
>>> "unk1" in "s->unk1" looks like a copy-paste error.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4724>
---
src/panfrost/pandecode/decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/panfrost/pandecode/decode.c b/src/panfrost/pandecode/decode.c
index faa01cd7517..32effb30f18 100644
--- a/src/panfrost/pandecode/decode.c
+++ b/src/panfrost/pandecode/decode.c
@@ -2422,7 +2422,7 @@ pandecode_samplers(mali_ptr samplers, unsigned sampler_count, int job_no, bool i
pandecode_prop("wrap_t = %s", pandecode_wrap_mode(s->wrap_t));
pandecode_prop("wrap_r = %s", pandecode_wrap_mode(s->wrap_r));
- if (s->unk1 != 0x8) {
+ if (s->unk8 != 0x8) {
pandecode_msg("XXX: unk8 tripped\n");
pandecode_prop("unk8 = 0x%x", s->unk8);
}
More information about the mesa-commit
mailing list